GithubHelp home page GithubHelp logo

Comments (9)

casbin-bot avatar casbin-bot commented on June 16, 2024

@seriouszyx @ComradeProgrammer @Resulte

from casdoor.

hsluoyz avatar hsluoyz commented on June 16, 2024

@leoncamel sounds good. Can you split the syncers to different issues? One issue for one syncer. Because one syncer itself is a big code change itself

from casdoor.

leoncamel avatar leoncamel commented on June 16, 2024

@hsluoyz Sure, I will submit idP related syncer as new issue. This issue remains as a umbrella issue to discuss general concepts.

from casdoor.

leoncamel avatar leoncamel commented on June 16, 2024

I add split it into #2624, #2625.

Currently, we have many Id-Providers, but not all of them are syncable/sychronisable. Some Id-Provider support additional APIs for Listing Users. Further more, some Id-Provider provide incremental APIs, like Microsoft's Graph API, which make its Syncer become a Stateful Syncer(since it need store last checkpoint position).

I just did a quick survey about these Id-Providers:

Provider Name Syncable Incremental Syncable
ADFS
AliPay
AzureADB2C
Baidu
Custom
Casdoor
DingTalk Yes
Douyin
Facebook
Gitee
Github
Gitlab Yes
Google
Goth
Infoflow Internal
Inforflow 3rd-party
Lark
Linkedin
MetaMask
Okta
QQ
Web3Onboard
WeChat
WeChat MiniProgram
WeCom Internal Yes #2625
WeCom 3rd-party Yes #2625
Weibo

Correct me if I was wrong.

from casdoor.

hsluoyz avatar hsluoyz commented on June 16, 2024

@leoncamel can you make PR?

from casdoor.

leoncamel avatar leoncamel commented on June 16, 2024

@hsluoyz

OK. We will try to make PR for this. But, I think it involve big refactor on frontend & syncer interface and some core logic. And we are not sure if this PR will match casdoor's rodmap.

We will give try to make first PR to open discussion on this.

from casdoor.

hsluoyz avatar hsluoyz commented on June 16, 2024

@leoncamel I think this can be implemented by a new syncer. There's no need to build on top of the OAuth provider. They use different APIs and have nothing much shared in common.

from casdoor.

leoncamel avatar leoncamel commented on June 16, 2024

@hsluoyz Yes.

But, I not sure how to share parameters between idP and its syncer. For the WeCom case, they may share ClientID and ClientSecret?

Any thoughts?

from casdoor.

hsluoyz avatar hsluoyz commented on June 16, 2024

@leoncamel no need to share. Just store it in syncer object for a second time

from casdoor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.