Comments (6)
Deleting a reengagement activity will always delete the in progress records before deleting the actual reengagement. The cron process responsible for sending e-mail also first gets a list of re-engagments in the site from the reengagements table and then for each current reengagment it will check to send the e-mails. So... I can't see how your first item can occur. Can you please provide more information/steps to reproduce this?
regarding your 2nd point - yes, I think I've seen something like this occur - the in progress records generated after the reengagment have been set up may not match the same rules - especially if you change activity restriction details etc. We probably need to look at a way to make it clear to the teacher what will happen when they change settings, or implement a way to clear out the in-progress records for a current reengagement when the settings change.
Feel free to help us work on this!
thanks.
from moodle-mod_reengagement.
I don't suppose you have a testing environment that has an old version of your production database and is sending out these e-mails?
from moodle-mod_reengagement.
Hi Dan,
We do have a test environment but I'm sure that's not sending the emails. The test environment did not hold the reengagement activities that created the problem.
Steps to recreate are pretty simple:
-
Create a reengagement activity and set it up
-
Wait for the cron to run (mine runs every 2 minutes)
-
Check in table mdl_reengagement_inprogress is populated.
-
Delete your reengagement activity
-
Check your course recycle bin: it will not be there
-
Wait for the cron to run or run it manually
-
Check table mdl_reengagement_inprogress, in my Moodle (3.5.2) it is still populated
-
Check table mdl_reengagement, it still has your reengagement activity
Dan, just a suggestion: I think this activity would be a lot clearer if, when you view the activity, it shows exactly which user will get notified. And when. And if possible: for how many times. And the end date of notification.
Also: make sure that the users who will not be notified (for example when they turned in an assignment you are monitoring) are recognizable in the list. This way a teacher who sets it up will understand which user is notified.
Right now, in the notification-list are also users that have already completed the assignment you are monitoring. They even have a date on which they will be notified, but they should not be notified because they have already completed the activity you are monitoring.
from moodle-mod_reengagement.
I suspect you have an issue on your site with ad-hoc tasks which are responsible for running the module deletion process. When a module is deleted the "deletioninprogress" flag is set in the course_modules table and then the ad-hoc task should do the actual deletion.
We can look at adding a check for this field prior to sending any e-mails and exclude any modules that are currently being deleted - but you should check to see why this ad-hoc task isn't running on your site because it could cause you other problems too..
Yeah - the list of users displayed when viewing the activity isn't great and it is definitely something that could be improved. Feel free to help us work on this. (funding and pull requests always welcome.)
thanks!
from moodle-mod_reengagement.
I've just dropped a patch into all branches 3.2 and higher and Totara 10 and higher which is where the deletioninprogress db change landed. Hopefully it helps!
from moodle-mod_reengagement.
Thanks!
from moodle-mod_reengagement.
Related Issues (20)
- Debugging warning message in view page HOT 1
- Send Notifications to specific Cohorts HOT 1
- Cron task default schedule interval HOT 1
- Alert the training manager about pending grading HOT 1
- Re-engagement activity - Participants not correctly marked as complete HOT 1
- Only 236 members are sent a mail HOT 2
- Notify time never updates HOT 1
- Notify time is universal, not by course and activity HOT 3
- access restriction do not work if added later HOT 1
- Moodle 4.3 - Deprecated get_all_user_name_fields() HOT 1
- Duplicate of Reengagement activity HOT 1
- Feature Request - email placeholders in on-line help in Moodle HOT 1
- Add suffix for completion rules on Moodle 4.3+ HOT 1
- Notify time shows random time not the next message send time HOT 3
- JS Error in reengagement/view.php in moodle 4.4
- Feature request for Cron-Task (adhoc, availability-restriction) HOT 7
- Notifications are send out after editing an existing instance of reengagement HOT 1
- Emails do not respect edited enrol dates HOT 1
- Dropdown not working in participant view HOT 1
- Update completion time - but no button to do the action.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moodle-mod_reengagement.