Comments (3)
Fixed in react-pages
: content-type
not set explicitly and multipart/form-data
has a boundary
.
from react-pages.
Hmmm, good thoughts.
https://stackoverflow.com/questions/5661596/do-i-need-a-content-type-for-http-get-requests
Says:
It means that the
Content-Type
HTTP header should be set forPUT
andPOST
requests.
At the same time, there's no prohibition of Content-Type
on GET
requests.
Still I guess setting Content-Type
manually for GET
requests could be removed from the code.
But if I changed that then it would be a breaking change.
We could add a flag for that, something like http.alwaysSetContentType: false
.
I also googled this:
ladjs/superagent#1202
Never set Content-Type with multipart, as it erases the boundary argument that has to be set by the browser.
Also this:
ladjs/superagent#1152
In the browser version the boundary is set automatically by
FormData
element and we have no control over it.
And they also say:
You can either use your own
content-type
and your own payload with.send() / .set()
OR you can let all of it being 100% auto-generated by the browser by using.attach() / .field()
. They don't mix.
I guess .send(new FormData(...))
will have to be rewritten as .attach() / .field()
(and then tested) and that would fix the FormData
part.
So, the fix would mean:
- Adding
http.alwaysSetContentType: false
flag. - Rewrite
HttpRequest.js
from sendingFormData
directly into using.attach() / .field()
and then test that it works.
I can do that when I have some time for that.
In the meanwhile you can use your workaround in onRequest()
.
from react-pages.
Well, I am not a fan of adding another flag which will be true by default. It will be a breaking change to remove that chunk of code, but you can add a code snippet within the changelog how to set default ContentType if someone needs it:
http: {
onRequest: request => {
if (!request.header['Content-Type']) {
request.set('application/json');
}
},
},
As to the FormData
, the idea to use attach/field
looks good, if you create a branch with a fix, I can check if it works.
Take your time, I can wait as I've got that workaround and it's not blocking me. I've created this issue especially that FormData looks to be broken.
Thanks for your time
from react-pages.
Related Issues (20)
- Access store outside React scope HOT 4
- Adding json-ld script tags (dynamic) in SSR pages HOT 1
- Can't add custom handler for `@@react-isomorphic-render/goto` event HOT 4
- Error running npm install HOT 1
- The test is failed. (npm install) HOT 1
- usage directions fail at npm install babel-node HOT 1
- SSR middlewares HOT 2
- react-router problem HOT 7
- Http utility in Server Side HOT 11
- how can i run this site? HOT 8
- How modify @preload {client: true} configuration HOT 5
- How to capture an event type HOT 2
- Crash in long running production process (v 2.0.13) HOT 2
- Module not found: Error: Can't resolve './aboutPageReducer' in ...... HOT 1
- Error instantiating router HOT 5
- No way to detect authentication before using http client HOT 2
- [SSR] Access to the request headers HOT 4
- Enable configuration entry for HTTP `on_before_send` HOT 8
- Moving from isomorphic to website causes render service error HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-pages.