Comments (3)
Looks like the problem is inside the following piece of code inside startWork()
.
if workErr := r.workFunc(in, r.outChan); workErr != nil {
r.once.Do(func() {
errors.As(err, &workErr)
r.cancel()
return
})
}
playing around with the code noticed that the when the err
is nil
(which is always) the error from the worker is not available. However, playing around the code and adding the following can see that the .As
function works
if workErr := r.workFunc(in, r.outChan); workErr != nil {
r.once.Do(func() {
err = context.Canceled
errors.As(err, &workErr)
r.cancel()
return
})
}
from go-workers.
@nanikjava, Thank you for taking the time to submit an issue. There is definitely an issue where an error will not bubble up. The unit tests for testing a return of an error did not catch it. I am submitting for review a fix for this issue.
from go-workers.
Tested the referenced PR #31 and it works.
Closing the ticket.
from go-workers.
Related Issues (2)
- Worker Time outs HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-workers.