GithubHelp home page GithubHelp logo

Make cayley go gettable about cayley HOT 4 CLOSED

cayleygraph avatar cayleygraph commented on July 30, 2024
Make cayley go gettable

from cayley.

Comments (4)

barakmich avatar barakmich commented on July 30, 2024

It's worth considering. What sorts of invasive changes? Not necessarily opposed to them, just having some more context before I say "yeah, go ahead!" would be cool.

from cayley.

kortschak avatar kortschak commented on July 30, 2024

I'm just relaxing into it at the moment, so you can have a look and feel free to reject.

from cayley.

kortschak avatar kortschak commented on July 30, 2024

The changes are here. I'll send a PR and sign a CLA if you're happy with that.

There are other changes that I think would be worthwhile to get the code to be more Go-idiomatic and which should ease reading, but I'll wait on whether your not averse to this load first.

from cayley.

barakmich avatar barakmich commented on July 30, 2024

Yeah, send the PR. I'll do a full review later tonight (when I get away from I/O) but my initial glance made me go "oh, neat!" so that's a good sign. When I get ready to accept the PR, at that point you can do the CLA (and add yourself to the CONTRIBUTORS file).

from cayley.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.