Comments (6)
Yep -- we are planning to do a gometalinter over the whole codebase in the near future and chase down all the issues.
from cayley.
I'd suggest a stronger approach to linting that what you have there. The golangci-lint metalinter does a good job and allows exclusions. The SAAS that they used to provide doesn't exist anymore, but it can be replicated in your CI. We do it like so: https://github.com/gonum/gonum/blob/master/.travis/script.d/check-lint.sh
from cayley.
Now there are only documentation warnings:
imports.go:5:2: a blank import should be only in a main or test package, or have a comment justifying it
imports.go:8:2: a blank import should be only in a main or test package, or have a comment justifying it
imports.go:12:2: exported var StartMorphism should have comment or be unexported
imports.go:18:6: exported type Iterator should have comment or be unexported
imports.go:19:6: exported type QuadStore should have comment or be unexported
imports.go:20:6: exported type QuadWriter should have comment or be unexported
imports.go:22:6: exported type Path should have comment or be unexported
imports.go:24:6: exported type Handle should have comment or be unexported
imports.go:29:1: exported method Handle.Close should have comment or be unexported
imports.go:35:1: exported function Triple should have comment or be unexported
imports.go:39:1: exported function Quad should have comment or be unexported
imports.go:43:1: exported function NewGraph should have comment or be unexported
imports.go:55:1: exported function NewMemoryGraph should have comment or be unexported
Once they will be resolved we can CI on golint
to make sure we don't introduce new errors.
from cayley.
Actually, I ran only on the top level
from cayley.
Lint should be done by bash lint.sh
as it has defined ignored patterns.
from cayley.
This looks really cool. If you'd like to integrate this approach it would be very welcome.
from cayley.
Related Issues (20)
- 'go build ./cmd/cayley' breaks: missing go.sum entry for module providing package github.com/golang/protobuf/proto HOT 3
- Move cayley.io to Github Pages or Netlify or similar HOT 1
- Aggregations
- Code quality: NameOf and ValueOf should return errors HOT 2
- Relationships not displaying correctly in new cayley version HOT 1
- Cayley.io is down again HOT 10
- Seeking for a new maintainer HOT 13
- hidalgo: interfaces changed a bit in newer versions HOT 2
- Security issue with github.com/gogo/protobuf version < 1.3.2 HOT 2
- Repl Allows One Command to Execute and Subsequent Commands Fail HOT 1
- request a new release HOT 1
- Filter path by Label field of quads HOT 1
- Filter path by empty label field (FilterContext) HOT 1
- Plans for a new release? HOT 2
- Build Issue using cayley 0.7.7 HOT 1
- q InternalQuad ==> q *InternalQuad
- gio gui HOT 1
- Plans for a new release?
- Discourse forum down
- Is this project dead? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cayley.