Database Host not picked up from portal.properties about cbioportal

[serverhorror]

It seems that around Line 226 the settingsKey shouldn't actually contain a hardcoded URI to MySQL

[tjrivera]

I've also run into this issue. Should the build process use the database defined here: https://github.com/cBioPortal/cbioportal/blob/master/src/main/resources/portal.properties.EXAMPLE#L7 to run its tests during build?

[serverhorror]

I think the the maven settings is definitely the wrong place to look for cBioportal settings. Im in favor of the portal.properties.

[jjgao]

@serverhorror @tjrivera Have you solved the problem? Database should be configured in Tomcat context.xml file.

https://github.com/cBioPortal/cbioportal/wiki/Pre-Build-Steps#configure-the-database-connection-pool-resource-to-apache-tomcat

[tjrivera]

@jjgao I think this refers specifically to the build process and the fact that the MySQL db that is used to test against during the build is hardcoded here.

e80fac1#diff-357e4854869b2e21c38b1b437f11095aR226
(Line 226)

This makes it impossible to build cBio on a machine that doesn't have a MySQL instance running on localhost. I've worked around this by building the application with Docker containers but perhaps the test db should also be configurable?

[inodb]

I fixed the problem of not being able to build the war without mysql in #605 when the parameter -DskipTests is supplied to mvn. You still can't set the test db in the properties file however.

[serverhorror]

How's it going with this? Any fix yet?

[jjgao]

Closing now. Not sure if it's still a problem. Please reopen if it is.