Comments (11)
Hello @Akshatji800
Please review my pull request #241
Thank you
from flood_mobile.
Hello @Akshatji800 Please review my pull request #241 Thank you
Hello @andoriyaprashant I will review the PR soon.
from flood_mobile.
Ok Thank you @Akshatji800 :)
from flood_mobile.
Hello @Akshatji800
You had asked me to review my pull request. Please provide your response.
Thank you
from flood_mobile.
Hello @Akshatji800 You had asked me to review my pull request. Please provide your response. Thank you
Hello @andoriyaprashant, I just reviewed your PR and there are some things which needs to be addressed before the PR can be merged-
- The Flutter CI is failing as the Flutter version given in the workflow is 3.7.11 and you probably migrated everything to the latest flutter version 3.10 so please change the version in workflow as well.
- I tested things in my local and got some errors in some part of code due to updated new packages version, many of the functions have been changed and since old version functions were used so they will obviously give errors. For Example:
Here the BadgeColour line is showing an error as in the new badge package the BadgeColour is moved to BadgeStyle.
You need to resolve tsuch errors as well if you want to get your PR merged.
from flood_mobile.
I will test all the dependencies versions on the code to ensure compatibility with the new Flutter version, and then I will create a new PR. Thank you so much for providing feedback.
@Akshatji800
from flood_mobile.
Hey @Akshatji800 I have made the changes you asked me to make, such as making the dependencies compatible with the Flutter version. Please check #245 and let me know.
Thank you.
from flood_mobile.
may i fix this @Akshatji800 ??
from flood_mobile.
Can I work on this issue ?
from flood_mobile.
@simplybest12 @lalitkumawat1m This issue is already being worked on by the issue creator @andoriyaprashant himself.
from flood_mobile.
Can you assign this issue to me @Akshatji800
from flood_mobile.
Related Issues (20)
- Clear filter feature on no torrent display HOT 1
- Enhancement in the intro page HOT 6
- Snackbar on set download and upload speed
- Fix logout alert dialogue box HOT 3
- Any chance to get updates? HOT 8
- Implement pagination in the RSS feed screen. HOT 10
- Torrent doesn't get removed from device notifications after deleting. HOT 3
- Theme bug in RSS-Feed's browse feeds option torrents display. HOT 3
- RSS-Feed getting added on UI screen even without any connection to backend. HOT 6
- RSS-Feed page textfields doesn't get reset after saving/adding the rss-feed. HOT 5
- 'Badge' is imported from 2 packages
- commit, issues, and PR are not aligned in the centre
- Widget doesn't adapt to light mode HOT 2
- Add Sound Null Safety at various places in codebase HOT 3
- Provider to Bloc Migration HOT 2
- Address Warnings and Enhance Code Quality in Flood_Mobile Project
- Revise qBittorrent Instructions and Clarify Environment Setup in CONTRIBUTING.md HOT 2
- please add support for azureus/vuze/bigly bt
- Application out of date HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flood_mobile.