GithubHelp home page GithubHelp logo

Comments (11)

andoriyaprashant avatar andoriyaprashant commented on September 23, 2024

Hello @Akshatji800
Please review my pull request #241
Thank you

from flood_mobile.

Akshatji800 avatar Akshatji800 commented on September 23, 2024

Hello @Akshatji800 Please review my pull request #241 Thank you

Hello @andoriyaprashant I will review the PR soon.

from flood_mobile.

andoriyaprashant avatar andoriyaprashant commented on September 23, 2024

Ok Thank you @Akshatji800 :)

from flood_mobile.

andoriyaprashant avatar andoriyaprashant commented on September 23, 2024

Hello @Akshatji800
You had asked me to review my pull request. Please provide your response.
Thank you

from flood_mobile.

Akshatji800 avatar Akshatji800 commented on September 23, 2024

Hello @Akshatji800 You had asked me to review my pull request. Please provide your response. Thank you

Hello @andoriyaprashant, I just reviewed your PR and there are some things which needs to be addressed before the PR can be merged-

  • The Flutter CI is failing as the Flutter version given in the workflow is 3.7.11 and you probably migrated everything to the latest flutter version 3.10 so please change the version in workflow as well.
  • I tested things in my local and got some errors in some part of code due to updated new packages version, many of the functions have been changed and since old version functions were used so they will obviously give errors. For Example:
    image
    Here the BadgeColour line is showing an error as in the new badge package the BadgeColour is moved to BadgeStyle.
    You need to resolve tsuch errors as well if you want to get your PR merged.

from flood_mobile.

andoriyaprashant avatar andoriyaprashant commented on September 23, 2024

I will test all the dependencies versions on the code to ensure compatibility with the new Flutter version, and then I will create a new PR. Thank you so much for providing feedback.
@Akshatji800

from flood_mobile.

andoriyaprashant avatar andoriyaprashant commented on September 23, 2024

Hey @Akshatji800 I have made the changes you asked me to make, such as making the dependencies compatible with the Flutter version. Please check #245 and let me know.
Thank you.

from flood_mobile.

simplybest12 avatar simplybest12 commented on September 23, 2024

may i fix this @Akshatji800 ??

from flood_mobile.

lalitkumawat1m avatar lalitkumawat1m commented on September 23, 2024

Can I work on this issue ?

from flood_mobile.

Akshatji800 avatar Akshatji800 commented on September 23, 2024

@simplybest12 @lalitkumawat1m This issue is already being worked on by the issue creator @andoriyaprashant himself.

from flood_mobile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.