Comments (9)
I can confirm #58 fixes the issue and the tests now pass.
from wsgi-intercept.
@temoto this might be a bug in httplib2 and I can trace it to the 0.13.0 too, 0.12.3 was passing all the tests here.
from wsgi-intercept.
By here I mean that if you look on the travis run of the last commit it is passing because it used the old httplib2.
from wsgi-intercept.
I suspect the main issue here is that the interface in httplib2 has changed slightly and the rather tricky monkey-patching that wsgi-intercept is doing no longer works.
I'll investigate this quickly and if I don't see a quick path to fixing it I'll do a release that pins to an earlier version of httplib2 and do the harder fix later.
from wsgi-intercept.
Culprit: https://github.com/cdent/wsgi-intercept/blob/master/wsgi_intercept/httplib2_intercept.py#L33
def __init__(self, host, port=None, strict=None, timeout=None,
proxy_info=None, ca_certs=None, source_address=None,
disable_ssl_certificate_validation=False,
ssl_version=None):
Solution: accept **kwargs.
from wsgi-intercept.
Solution: accept **kwargs.
Yes, that's where I'm at.
The original authors didn't use kwargs so I maintained the pattern when I took over maintenance, but it no longer seems worth the effort.
from wsgi-intercept.
see #58
from wsgi-intercept.
I've released a 1.9.0 that has the fix: https://pypi.org/project/wsgi-intercept/
from wsgi-intercept.
This was fixed way back when by #58 so should have been closed then.
from wsgi-intercept.
Related Issues (20)
- Feature request: Add optional before_intercept and after_intercept callbacks HOT 8
- kwarg error when $http_proxy is set in environ HOT 7
- Including LICENSE file in the code repository and Adding it in the Manifest file HOT 4
- unexpected keyword argument 'source_address' HOT 3
- Please allow to disable internet tests HOT 3
- wsgi_intercept.make_environ turns headers into unicode HOT 3
- When using the url arg to an Interceptor, if there is no port in the url an error happens
- wsgi-intercept should build in some character encoding checks
- Write ignores response body when first item in iterable is an empty string HOT 1
- urllib3 intercept cause TypeError with https URL HOT 8
- Logs / errors are lost due to `wsgi.errors` not extracted HOT 4
- Interceptor.uninstall_interceptor turns off intercept for all intercepts using the same module
- Pypi sdist tarball doesn't have README.rst HOT 3
- Missing 2 required positional arguments: 'environ' and 'start_response' with Django 2.2 HOT 4
- HTTPS connections with Requests library don't support verify=False to outside domains HOT 7
- Support aiohttp HOT 2
- Simple example fails with Python 2 HOT 5
- PEP517 HOT 4
- Incompatibility with pytest 7.2.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wsgi-intercept.