GithubHelp home page GithubHelp logo

Comments (9)

scarabeusiv avatar scarabeusiv commented on June 28, 2024 2

I can confirm #58 fixes the issue and the tests now pass.

from wsgi-intercept.

scarabeusiv avatar scarabeusiv commented on June 28, 2024

@temoto this might be a bug in httplib2 and I can trace it to the 0.13.0 too, 0.12.3 was passing all the tests here.

from wsgi-intercept.

scarabeusiv avatar scarabeusiv commented on June 28, 2024

By here I mean that if you look on the travis run of the last commit it is passing because it used the old httplib2.

from wsgi-intercept.

cdent avatar cdent commented on June 28, 2024

I suspect the main issue here is that the interface in httplib2 has changed slightly and the rather tricky monkey-patching that wsgi-intercept is doing no longer works.

I'll investigate this quickly and if I don't see a quick path to fixing it I'll do a release that pins to an earlier version of httplib2 and do the harder fix later.

from wsgi-intercept.

temoto avatar temoto commented on June 28, 2024

Culprit: https://github.com/cdent/wsgi-intercept/blob/master/wsgi_intercept/httplib2_intercept.py#L33

    def __init__(self, host, port=None, strict=None, timeout=None,
            proxy_info=None, ca_certs=None, source_address=None,
            disable_ssl_certificate_validation=False,
            ssl_version=None):

Solution: accept **kwargs.

from wsgi-intercept.

cdent avatar cdent commented on June 28, 2024

Solution: accept **kwargs.

Yes, that's where I'm at.

The original authors didn't use kwargs so I maintained the pattern when I took over maintenance, but it no longer seems worth the effort.

from wsgi-intercept.

cdent avatar cdent commented on June 28, 2024

see #58

from wsgi-intercept.

cdent avatar cdent commented on June 28, 2024

I've released a 1.9.0 that has the fix: https://pypi.org/project/wsgi-intercept/

from wsgi-intercept.

cdent avatar cdent commented on June 28, 2024

This was fixed way back when by #58 so should have been closed then.

from wsgi-intercept.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.