GithubHelp home page GithubHelp logo

Comments (6)

ahmadsyafrudin avatar ahmadsyafrudin commented on July 28, 2024

please assign me this issue, i'll working on it @erkist

from sdk-python.

erkist avatar erkist commented on July 28, 2024

Done, thank you @ahmadsyafrudin! Looking forward to the PR!

from sdk-python.

ahmadsyafrudin avatar ahmadsyafrudin commented on July 28, 2024

HI @erkist , Please Elaborate more about the goals.
What I thought Is just added command to makefile that generate code coverage for this project. is that what we want ?
and also what is the report type that we want?
do we need code coverage badge on readme.md also?
last but not least, do you already have https://app.codecov.io/ account? or I can skip coverage badge part if we don't want it.
Thanks 🙏🏻

from sdk-python.

ahmadsyafrudin avatar ahmadsyafrudin commented on July 28, 2024

#9 Kindly check and reveiw my pull request. thanks

from sdk-python.

erkist avatar erkist commented on July 28, 2024

@ahmadsyafrudin I'm very happy with what you have put in place already, as it allows me to get the following:

$ coverage report
Name                            Stmts   Miss  Cover
---------------------------------------------------
cdevents\core\__init__.py           1      0   100%
cdevents\core\artifact.py          20      0   100%
cdevents\core\branch.py            20      0   100%
cdevents\core\build.py             24      0   100%
cdevents\core\env.py               25      0   100%
cdevents\core\event.py             16      3    81%
cdevents\core\event_sender.py      11     11     0%
cdevents\core\event_type.py        24      0   100%
cdevents\core\http_handlar.py      95     95     0%
cdevents\core\pipelinerun.py       27      0   100%
cdevents\core\repository.py        25      0   100%
cdevents\core\service.py           29      0   100%
cdevents\core\taskrun.py           21      0   100%
---------------------------------------------------
TOTAL                             338    109    68%

As of right now I don't see a need for badges or codecov integration, so I will close this issue with your fix, but I am curious as to the next steps you have mentioned so I will create follow-up issues to look into them.

from sdk-python.

erkist avatar erkist commented on July 28, 2024

Solved by @ahmadsyafrudin in PR #9

from sdk-python.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.