GithubHelp home page GithubHelp logo

Comments (8)

codedance avatar codedance commented on September 16, 2024

As a followup, I was thinking about the name GetTable. I'm not sure it's the right name. The implementation looks more like a (sub)tree walk. Table's in SNMP/MIB have a different context. i.e.

http://www.webnms.com/snmp/help/snmpapi/snmpv3/table_handling/snmptables_basics.html

from wapsnmp.

cdevr avatar cdevr commented on September 16, 2024

Wow, what a brilliant bug report ! Thanks. I am ashamed to admit, it explains a few things.

Issue number 3 has been fixed. This was actually a problem we encountered in production. I guess I read the standard and interpreted things a little too literally. It says all oid's start with .1.3. Wrong.

from wapsnmp.

cdevr avatar cdevr commented on September 16, 2024

I'm hoping 39d42da fixes the GetTable problem.

from wapsnmp.

cdevr avatar cdevr commented on September 16, 2024

I have followed suggestions 1 and 2.

from wapsnmp.

codedance avatar codedance commented on September 16, 2024

Thanks for picking up the issues. I've been working with Sonia on her branch of GoSNMP and we're added quite a few new features: https://github.com/soniah/gosnmp

The more and more I dive into SNMP the more corner cases we come across. There are a lot of agent implementations out there and they all have their idiosyncrasy. It's hard work!

I like many of the concepts in WapSNMP and are looking at borrowing a few such as your concept of MustParseOid() and centralising the BER parsing code. I'm not sure what your plans are for the project. The two code bases are quite different, but l'm sure sharing knowledge would be well worth it.

from wapsnmp.

cdevr avatar cdevr commented on September 16, 2024

Wow you've been hard at work on that branch. I'm hoping the project can become a full SNMP implementation for Go. Lots of things are being implemented in various branches, and I'd love to bring them together. I was hoping you guys would sign the Google CLA, and I would be able to really integrate your changes.

https://developers.google.com/open-source/cla/individual?csw=1

Do you think working like this would be possible ?

from wapsnmp.

codedance avatar codedance commented on September 16, 2024

Personally I don't have any issue in signing the agreement. Is this because the code is internally used in Google?

from wapsnmp.

cdevr avatar cdevr commented on September 16, 2024

Well it's standard procedure for code that is maintained and used within Google. I don't know the exact details however.

from wapsnmp.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.