GithubHelp home page GithubHelp logo

Comments (6)

cebe avatar cebe commented on May 22, 2024

Thanks for pointing this out! I am aware of this issue but was not sure how or whether to fix it at all. The original specs are not 100% clear about it and there are cases where you do not want this to work.
e.g.

Lorem ipsum dolor sit amet. The company xyz was founded in
1985. After that it grew....

You do not want to have a list started here.

Current implementation expects a blank line between different block elements. Will check how we can fix this.

from markdown.

samdark avatar samdark commented on May 22, 2024

For the cases mentioned it's all about blank lines after headers. I don't think these are mandatory in this case.

from markdown.

iJackUA avatar iJackUA commented on May 22, 2024

@samdark not only header
in first case Header without line break "killed" first line under it
and in second case hr element killed header under it

it is really unexpected behavior
for example from GitHub's markdown manual

# The largest heading (an <h1> tag)
## The second largest heading (an <h2> tag)
…
###### The 6th largest heading (an <h6> tag)

total mess

selection_082

from markdown.

samdark avatar samdark commented on May 22, 2024

Well, yeah. HR is the same case where it doesn't make sense to require extra space.

from markdown.

cebe avatar cebe commented on May 22, 2024

Working on a fix already.

from markdown.

cebe avatar cebe commented on May 22, 2024

Should all be fixed by 8d035ac. If you encounter more cases like this (even if they pass), please add them to the test file or paste them here.

from markdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.