Job info in handler about fivebeans

[bryanlarsen]

In our fork (Exocortex/fivebeans) we add the stats to the payload as _stats, if payload is an object. There are a bunch of other hacks in there that we should PR. But this one and some timeout/failure detection we've added are pretty hacky -- probably trying too hard to avoid changing the API.

[ceejbot]

I'm totally okay with changing the API where it's sensible, or even handing over ownership of the project if you're up for it! I don't have this in production at the moment, so I don't have the incentive to drive it forward the way somebody who does have it in production has.

[imjoshholloway]

+1 on adding a key to the payload (something like $job) maybe?

[cmawhorter]

+1 and making a change but payload is payload imo and I don't think this belongs there.

Howsabout changing this to be this:

switch(handler.work.length) {
  default: // do what is done now
  case 3: // use signature (id, payload, callback) or whatever
}

That's less than ideal though. If API changes are on the table I'd like to see the handler implementation reworked.

[cmawhorter]

FWIW-- I implemented my suggestion in a patch and it is working for me. All tests pass too.

var fivebeans = require('fivebeans');
var _fivebeansWorkerCallHandler = fivebeans.worker.prototype.callHandler;
fivebeans.worker.prototype.callHandler = function(handler, jobID, jobdata)
{
  switch (handler.work.length) {
    case 3:
      var patchedHandler = {
        work: function(payload, callback) {
          return handler.work(jobID, payload, callback);
        }
      };
      return _fivebeansWorkerCallHandler.call(this, patchedHandler, jobID, jobdata);
    default:
      return _fivebeansWorkerCallHandler.apply(this, arguments);
  }
};

[ceejbot]

Cool, ty for this! Will advise when it's released.

[ceejbot]

Published on npm as v1.3.0, including version bumps for dependencies.

[cmawhorter]

Wow, awesome!