Comments (14)
@kpreisser Thanks for the reminder. The changes will need to be reverted as per my comment above.
from cef-binary.
Commit 8a902f2 adds the required props.
Haven't tested to see if the folder structure for the swiftshader/locales directories is preserved.
from cef-binary.
There was a problem with the net core package when using a runtime identifier, the locales/swiftshader files weren't being copied. Revert changes for now.
from cef-binary.
It doesn't look like moving the locales/swiftshader into the arch packages is possible for the net core packages. It may still be possible though not worth the effort.
from cef-binary.
Hi @amaitland,
after upgrading to CefSharp.Common.NETCore 93.1.70-CI4201
(with chromiumembeddedframework.runtime 93.1.11
), we face the issue that the locales
and swiftshader
folders are no longer copied when using a RuntimeIdentifier like win-x64
, and thus resources fail to load. Can the changes for this be reverted/fixed?
Thanks!
from cef-binary.
If you remove the packages from your cache and redownload them the problem should be resolved.
build https://ci.appveyor.com/project/cefsharp/cef-binary/builds/40634148 using https://github.com/cefsharp/cef-binary/tree/cef/93
I've left master
unchanged as I'll test replacing the runtime.json
with a .props/.targets
file that adds the PackageReference
entries based on RuntimeIdentifier
If that doesn't work then it's likely this idea won't work.
from cef-binary.
If you remove the packages from your cache and redownload them the problem should be resolved.
build https://ci.appveyor.com/project/cefsharp/cef-binary/builds/40634148 using https://github.com/cefsharp/cef-binary/tree/cef/93
Thanks! Using these new packages seems to work.
from cef-binary.
It appears that swiftshader
is being replaced and at some point in the future we can stop shipping the swiftshader
folder as the new dlls are included in the base directory. This will simplify our packages slightly and potentially make deprecating cef.redist easier as we only have to deal with the locales, which are likely duplicated between the different archs currently (haven't confirmed this, will need to hash them all and confirm the files are the same across the three archs)
Reference https://bitbucket.org/chromiumembedded/cef/issues/3176/win-linux-ship-vk_swiftshaderdll-vulkan
from cef-binary.
Issue https://bugs.chromium.org/p/chromium/issues/detail?id=1060139 tracks removing of Swiftshader
.
Once Swiftshader
has been removed moving locales
into a new package should be fairly trivial. I haven't checked though I suspect that locales
are the same for each arch at least the windows ones
, so we can possibly just ship a single set of files.
If we only need to ship a single set of locales
then it might be possible to use contentfiles to include the relevant files and programmatically set CefSettings.LocalesDirPath
. Haven't done any testing around this yet.
from cef-binary.
Removing of SwiftShader
has started https://bugs.chromium.org/p/chromium/issues/detail?id=1060139#c124
from cef-binary.
Swiftshader has been removed in M102
https://bitbucket.org/chromiumembedded/cef/commits/916360e2e5805e90dd69d2b3a944e16fb929ac50
from cef-binary.
We've exceeded the quote limits on MyGet
so the old cef.redist
packages will no longer be generated going forward.
They newer chromiumembeddedframework.runtime
packages will be used in CefSharp
. Anyone using the cef.redist
pacakges directly will need to migrate as well.
from cef-binary.
cef.redist.x64 => chromiumembeddedframework.runtime.win-x64
cef.redist.x86 => chromiumembeddedframework.runtime.win-x86
from cef-binary.
cef.redist.x64 => chromiumembeddedframework.runtime.win-x64
cef.redist.x86 => chromiumembeddedframework.runtime.win-x86
The packages have now been marked as deprecated on Nuget.org
.
from cef-binary.
Related Issues (20)
- 'CEF' folder inside NuGet package, despite 'lib' as standard. HOT 2
- Adding cefsharp to the project adds both x64 and x86 HOT 1
- VS2019 not found with VS2022 target HOT 1
- Deploy app with cefsharp as ClickOnce HOT 1
- MacOS packages missing HOT 4
- Request for 116.0.27+gd8c85ac+chromium-116.0.5845.190 HOT 2
- Could you also build Ungoogled ones? From Ungoogled-chromium HOT 2
- cef.redist.x64 is missing NuGet package README file HOT 1
- cef.redist.x64 and cefredist.x86 missing version > 120.2.7 on Nuget HOT 1
- Build.ps1 - Update chromiumembeddedframework.runtime.json version number
- Add license to cef.redist HOT 2
- Cef sharp x64, x86 cef redist update error HOT 4
- How to use cef.sdk.mp4support? HOT 1
- cef.redist x86/x64 make props transitive
- Adding all supported runtimes? HOT 1
- CEF now requires Visual Studio 2019 HOT 3
- CEF binaries v92.0.14 missing from myget HOT 3
- build.ps1 - Add option to package a subset of the support architectures HOT 1
- Missing cef_library_loader.h HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cef-binary.