Comments (15)
@niamster I am good with that. I'd like to do a bit of testing, in particular try it with celluloid-0.17.0
prerelease and push a pre1
of this release until the release of celluloid
also lands, then we bump both over to 0.17.0
- what do you think?
from celluloid-zmq.
If nothing else it would be good to update the gemspec and version on master to reflect that the current codebase is 0.17.0.pre... and after you do that, probably just cut a pre.
from celluloid-zmq.
Running transpec
on it and looking at the failing tests.
from celluloid-zmq.
@niamster the tests are outdated. Just running transpec
didn't fix them. I feel like we should have the mandatory cases green at least before cutting even a prerelease gem. I'd do this right now myself, but I am working on 0.17.0
of celluloid
-- but I can come back to this if no one else is able to get on this.
from celluloid-zmq.
@digitalextremist let me help you with that. I'll update the tests
from celluloid-zmq.
Sweet. Thanks @niamster
from celluloid-zmq.
@digitalextremist PR #43 is ready
from celluloid-zmq.
Right on! Heading back to my desk in 60-90 minutes and I'll go through that. Thanks again @niamster
from celluloid-zmq.
@digitalextremist I think #45 can be "safely" merged now.
from celluloid-zmq.
@niamster even without 0.17.0
of celluloid
itself?
from celluloid-zmq.
@niamster I found a few things and noted those on the individual lines. The question is: should master
of celluloid-io
depend on 0.17.0-prerelease
of celluloid
right away? I still need at least two more days before I'd say that's wise. Even then, I'd like to push a 0.17.0.pre1
of celluloid-zmq
with these sorts of changes... how about that?
from celluloid-zmq.
ah, you are right. I thought that we have 0.17.0-prerelease here. I agree that celluloid-xxx master branches should be synchronous.
from celluloid-zmq.
@niamster agreed, let's synchronize the versions. Feel free to bring #45 back in against a 0.17.0-prerelease
branch of celluloid-zmq
instead of master
from celluloid-zmq.
I will update #48 to be 0.17.0
instead of 0.16.5
in light of this.
from celluloid-zmq.
Especially to resolve the issues coming up in DCell, I am going to cut this in the next day or so, but as 0.17.0
to begin synchronizing versions across the suite.
from celluloid-zmq.
Related Issues (20)
- The libzmq version 2.0.7 is incompatible with ffi-rzmq HOT 3
- No License.txt HOT 1
- exclamation mark HOT 2
- PubSocket : writing to a specific topic HOT 2
- require of celluloid-io is no longer needed. HOT 1
- Class hierarchy deeper than one level breaks on 0.14.0 HOT 6
- No specs? HOT 1
- Support jeromq, jrzmq? HOT 3
- How to handle closing sockets? HOT 8
- zmq_proxy / ZMQ::Poll in Actor HOT 9
- Authentication and Encryption HOT 6
- Internal reactor lock on high message pressure in router-dealer pair HOT 2
- Multi-process example. HOT 1
- Assertion failed: check () (src/msg.cpp:248) HOT 7
- Port to rbczmq HOT 53
- Test suite broken HOT 1
- Function 'zlistx_head' not found HOT 3
- `rake spec` throw exceptions
- How thread safety is handle by Celluloid-ZMQ with ffi-rzmq HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from celluloid-zmq.