Gingerbread hardfork on alfajores node encountered bad block at activation block about celo-blockchain

[gastonponti]

@gitmewai can you double check that you are running the 1.8.0 version? Or maybe you are overriding the activation blocks

But in the error that you pasted is basically saying that you don't have the activation blocks set

Sep 11 17:31:28 celo-1 geth[14456]: ########## BAD BLOCK #########
Sep 11 17:31:28 celo-1 geth[14456]: Chain config: {ChainID: 44787 Homestead: 0 DAO: <nil> DAOSupport: true EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul: 0 Churrito: 4960000, Donut: 4960000, Espresso: 9472000, Gingerbread: <nil>, Gingerbread P2: <nil>, Engine: istanbul}
Sep 11 17:31:28 celo-1 geth[14456]: Number: 19814000

Those Gingerbread: <nil>, Gingerbread P2: <nil> should be set. And the actual block failing is the HF (19814000)

[gitmewai]

@gastonponti you are right that after we restarted the node, the gingerbread and its P2 are both set as Gingerbread: <nil>, Gingerbread P2: <nil>. Full logs attached below, also stating the version as v1.8.0:

Sep 11 17:59:19 celo-1 geth[14456]: INFO [09-11|17:59:19.877] Blockchain stopped
Sep 11 17:59:20 celo-1 systemd[1]: celo.service: Succeeded.
Sep 11 17:59:20 celo-1 systemd[1]: Stopped celo.service.
Sep 11 17:59:20 celo-1 systemd[1]: Started celo.service.
Sep 11 17:59:20 celo-1 geth[13245]: INFO [09-11|17:59:20.747] Maximum peer count                       ETH=50 LES=0 total=50
Sep 11 17:59:20 celo-1 geth[13245]: WARN [09-11|17:59:20.750] Disable transaction unindexing for archive node
Sep 11 17:59:20 celo-1 geth[13245]: INFO [09-11|17:59:20.750] Enabling recording of key preimages since archive mode is used
Sep 11 17:59:20 celo-1 geth[13245]: INFO [09-11|17:59:20.750] Set global gas inflation rate            rate=1.300
Sep 11 17:59:20 celo-1 geth[13245]: INFO [09-11|17:59:20.750] Set global gas cap                       cap=25,000,000
Sep 11 17:59:20 celo-1 geth[13245]: INFO [09-11|17:59:20.750] Allocated trie memory caches             clean=307.00MiB dirty=0.00B
Sep 11 17:59:20 celo-1 geth[13245]: INFO [09-11|17:59:20.751] Allocated cache and file handles         database=/home/celo/node/celo/chaindata cache=512.00MiB handles=262,144
Sep 11 17:59:23 celo-1 geth[13245]: INFO [09-11|17:59:23.634] Opened ancient database                  database=/home/celo/node/celo/chaindata/ancient readonly=false
Sep 11 17:59:23 celo-1 geth[13245]: INFO [09-11|17:59:23.678] Initialised chain configuration          config="{ChainID: 44787 Homestead: 0 DAO: <nil> DAOSupport: true EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul: 0 Churrito: 4960000, Donut: 4960000, Espresso: 9472000, Gingerbread: <nil>, Gingerbread P2: <nil>, Engine: istanbul}"
Sep 11 17:59:24 celo-1 geth[13245]: INFO [09-11|17:59:24.778] Initialising Ethereum protocol           versions=[67] network=44787 dbversion=8
Sep 11 17:59:24 celo-1 geth[13245]: INFO [09-11|17:59:24.903] Loaded most recent local header          number=19,813,999 hash=8bf14d..0404e2 td=19,814,000 age=28m7s
Sep 11 17:59:24 celo-1 geth[13245]: INFO [09-11|17:59:24.903] Loaded most recent local full block      number=19,813,999 hash=8bf14d..0404e2 td=19,814,000 age=28m7s
Sep 11 17:59:24 celo-1 geth[13245]: INFO [09-11|17:59:24.903] Loaded most recent local fast block      number=19,813,999 hash=8bf14d..0404e2 td=19,814,000 age=28m7s
Sep 11 17:59:25 celo-1 geth[13245]: INFO [09-11|17:59:25.107] Loaded local transaction journal         transactions=0 dropped=0
Sep 11 17:59:25 celo-1 geth[13245]: INFO [09-11|17:59:25.107] Regenerated local transaction journal    transactions=0 accounts=0
Sep 11 17:59:25 celo-1 geth[13245]: INFO [09-11|17:59:25.117] Starting peer-to-peer node               instance=celo/v1.8.0-stable-dbffebae/linux-amd64/go1.16.8
...
Sep 11 17:59:25 celo-1 geth[13245]: INFO [09-11|17:59:25.184] IPC endpoint opened                      url=/home/celo/node/geth.ipc
Sep 11 17:59:25 celo-1 geth[13245]: INFO [09-11|17:59:25.185] HTTP server started                      endpoint=x.x.x.x:8545 prefix= cors= vhosts=*
Sep 11 17:59:25 celo-1 geth[13245]: INFO [09-11|17:59:25.185] WebSocket enabled                        url=ws://x.x.x.x:8546

Do we have to manually specify the activation block (say configured in any config.toml file)? We compile the celo geth binary from source actually.

root@celo-1:/opt/celo_v1.8.0$ ls -l params/config.go 
-rw-r--r-- 1 celo celo 26693 Sep  7 09:53 params/config.go
root@celo-1:/opt/celo_v1.8.0$ grep -r 19814000 params/config.go 
		GingerbreadBlock:    big.NewInt(19814000),
		GingerbreadP2Block:  big.NewInt(19814000),
root@celo-1:/opt/celo_v1.8.0$ ls -l /usr/local/bin/geth 
lrwxrwxrwx 1 root root 31 Sep  7 09:55 /usr/local/bin/geth -> /opt/celo_v1.8.0/build/bin/geth
root@celo-1:/opt/celo_v1.8.0$ ls -l /opt/celo_v1.8.0/build/bin/geth
-rwxr-xr-x 1 celo celo 52396848 Sep  7 09:55 /opt/celo_v1.8.0/build/bin/geth

[gitmewai]

@gastonponti I found from the output of geth --help for celo v1.8.0:

  --override.gingerbread value        Manually specify the gingerbread fork block, overriding the bundled setting (default: 0)
  --override.gingerbreadp2 value      Manually specify the gingerbread p2 fork block, overriding the bundled setting (default: 0)

Does it mean that the default value is 0 rather than 19814000?

Thanks

[gastonponti]

Hi @gitmewai !

No, actually it doesn't have a default, so that's a misleading comment. That flag is mostly for testing purposes. You should manage to run the node without using that flag.

Are you building from the repo, right? And did you used the --alfajores flag?

[gastonponti]

Can you send us your config.toml? (remove all the passwords, addresses and things you don't want to share, those shouldn't matter)

[palango]

@gitmewai I'm closing this issue because we cannot reproduce this. If this is still an issue for you please leave a comment including the config.toml file and we'll investigate it further.