Comments (1)
i know this is old, but wanted to point out that this change breaks client code (shamefully, mine) which loads diffview.js/difflib.js dynamically via eval
and expects diffview
/difflib
to be declared globally after those scripts are loaded. (Granted, the use of eval
in the first place was not my best idea ever, but i'm hesitant to go back and patch otherwise unmaintained trees for this.) A different, backwards-compatible approach would have been:
window.diffview = {...}
And likewise for difflib
. That approach is semantically identical to the older approach, but is not in violation of strict mode.
Not a big deal, just pointing it out.
from jsdifflib.
Related Issues (20)
- Ignore diffs in comments HOT 1
- word level diff HOT 1
- Feature add: Line numbers from git diff
- README incorrect - "latter" should be "former" HOT 2
- Ignore whitespaces HOT 1
- Feature - knockoutjs customBindingHandler
- Indentation problem
- Highlight diff in an "updated line" HOT 1
- WHY THE FOLLOWING CODEING COULDN'T PASS THE EXAM ON https://oj.bnuz.edu.cn/problemset/7/problem/592,BUT OK ON dev c++ HOT 1
- Some information HOT 2
- Diff by group of lines
- Broken link in readme
- It's okey
- Demo URL link
- Contracts comparative HOT 2
- Filter to exclude unmodified rows, leaving rows where there are only changes HOT 1
- Browser crashed when use file more than 2mb .
- 0xc2132d05d31c914a87c6611c10748aeb04b58e8f
- babu90
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsdifflib.