Comments (4)
Hello, @anhnguyensgu!
There are 3 modes in current Redis broker implementation:
- Standalone Redis
- Redis with Sentinel
- Redis Cluster
For cases 1 and 2 pool size does not really matter - we utilize Redis pipelining and only several active connections from Centrifuge to Redis are active at any point of time.
I think pool size only matters in Redis Cluster case - where we are using pool to issue most of commands except publish without history
(which is pipelined).
I think in the near future Centrifuge Redis implementation may migrate from redigo
to go-redis
or possibly to rueidis
library - and those allow using pipelining for communication with Redis Cluster too. Pool size should not be too important in that case I believe.
So I think we should not expose pool size at this point. Do you have issues with current default pool size (which I think may happen only in Redis Cluster scenario)? If yes - we can address it more precisely, possibly looking how go-redis
from the mentioned pull request behaves - I think it should provide better overall throughput.
from centrifuge.
Thanks for your support. At this time, I have no issues with the pool, I will let you know if having any.
from centrifuge.
We migrated to rueidis library in #262 – where connection pool does not have much sense anymore, Centrifuge will use pipelining over several connections for all operations. So I suppose this issue can be closed.
from centrifuge.
The draft of blog post about rueidis migration: centrifugal/centrifugal.dev#18 - @anhnguyensgu probably you will be interested to check it
from centrifuge.
Related Issues (20)
- ServerJoin event not sent HOT 4
- client.send(data) disconnects clients on empty data HOT 2
- Occasional data race in `initMetricsRegistry` HOT 1
- Clients being disconnected due to "Slow" reason - throttling options HOT 14
- KeyDB connect HOT 3
- private channel HOT 2
- Deprecated ProtocolVersion1 will be removed soon HOT 1
- Client level heartbeat config HOT 7
- Custom recover at connection level HOT 4
- High memory consumption HOT 7
- Apply suggestions from fieldalignment for frequently used objects HOT 1
- Making send call to return a reply HOT 1
- Publish() causes a runtime error when no client subscribed to then channel. HOT 2
- [feature] presence with massive amount of active users HOT 6
- Remove SockJS transport HOT 1
- Embed Gorilla WebSocket HOT 1
- How Many Concurrent RPC Requests can server handle? HOT 2
- [feature] Return error when publishing with incorrect history TTL + history meta TTL configuration
- [bug] Investigate occasional panic in tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from centrifuge.