Comments (3)
I've started working on this. PR coming soon(ish).
from go-ceph.
I'm not familiar about librbd :( but I think I can tell about what I think.
I'm agreed about your opinion, I'm confused about Open
method's parameter when I use go-ceph
first
According to the tests and sources, c_snap_name
(string) and read_only
(boolean) are the only required parameters for the Open
method, And they are can be optional parameter. ("", false).
I think there are some options for idiomatic Go
- We can create two function
Open
,OpenReadOnly
for the feature because golang doesn't support function overloading. Maybe two function havestring
parameter forc_snap_name
- Create struct for
Open
parameter- in gophercloud, there are various option struct for support openstack api parameters
server, err := servers.Create(client, servers.CreateOpts{ Name: "My new server!", FlavorRef: "flavor_id", ImageRef: "image_id", }).Extract()
- Apply more declarative parameters. like
Open(readOnly bool, snapName string)
from go-ceph.
Anyone interested in this topic please look at #146 and provide feedback. We intend to change the typical workflow such that new open functions return the rbd Image type and Create functions only return an error (like the ceph apis).
from go-ceph.
Related Issues (20)
- NFSAdmin CreateCephFSExport API consistently failing in CI(main) HOT 4
- CentOS 7(EOL): CI jobs are failing on `nautilus`
- Update readme to reflect nautilus removal
- Missing rbd API components: function rbd_list HOT 1
- Rados Striping API Support HOT 6
- Support bucket scope quota HOT 4
- Add support for rbd_resize2
- Implement subvolume quiesce API HOT 4
- Need squid branch support
- Pacific CI jobs are failing with package dependencies HOT 5
- Should `Resize()` after `EncryptionLoad()` account for the encryption header space? HOT 7
- Quiesce test failing for pre-squid HOT 4
- TestCloneSubVolumeSnapshot failing on ceph main branch HOT 2
- APIs pending stability updates in v0.27.0
- APIs pending stability updates in v0.28.0
- TestRadosGWTestSuite/TestUserBucket is consistently failing in CI HOT 5
- API call to set image QoS HOT 2
- CI failures with pre-reef and main jobs HOT 1
- APIs pending stability updates in v0.29.0
- Build error on ioctx_octopus.go even will using -tags HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-ceph.