GithubHelp home page GithubHelp logo

Comments (6)

vandamm avatar vandamm commented on May 27, 2024 1

@KELiON it's easy:

  1. Invoke Cerebro window
  2. Press Cmd+W (I'm on Mac)
  3. Invoke Cerebro window again
Uncaught Exception:
Error: Object has been destroyed
    at Error (native)
    at exports.default.appWindow (/Applications/Cerebro.app/Contents/Resources/app.asar/webpack:/app/main/createWindow/toggleWindow.js:6:17)
    at click (/Applications/Cerebro.app/Contents/Resources/app.asar/webpack:/app/main/createWindow/AppTray.js:41:22)
    at MenuItem.click (/Applications/Cerebro.app/Contents/Resources/electron.asar/browser/api/menu-item.js:52:9)
    at Function.executeCommand (/Applications/Cerebro.app/Contents/Resources/electron.asar/browser/api/menu.js:121:15

Still happens on 0.2.6

from cerebro.

alexhx5 avatar alexhx5 commented on May 27, 2024 1

@KELiON @maximbaz these guys here https://github.com/tinytacoteam/zazu are using a different approach and their app's search bar doesn't have this issue, it is getting closed only by pressing Esc or clicking outside the window. In their case alt + f4 is closing the app itself (not only the search bar), I think that's how it should be for Cerebro, this approach will resolve the problem with referencing a destroyed object and raising this exception. What do you think of that guys?

from cerebro.

KELiON avatar KELiON commented on May 27, 2024

@benone do you have any steps to reproduce it?

from cerebro.

KELiON avatar KELiON commented on May 27, 2024

@vandamm thanks! Going to fix it in next release. Btw, what do you expect when you use cmd+w on mac – that you close an app and have to start it again, or you just close the window and can toggle it again with hotkey?

from cerebro.

KELiON avatar KELiON commented on May 27, 2024

@AlexAlabyev can you please answer my previous question? I'm not sure what is better way to do on windows

from cerebro.

alexhx5 avatar alexhx5 commented on May 27, 2024

@KELiON sorry, what is the question are you referring to? Are you asking whether or not I can open the search bar after triggering the error on Windows? If that's what you meant, the answer is no, I have to close the cerebro app and restart it every time this error pops up.
(The error can be triggered by alt + f4 while search bar is opened)

Do you think this function might resolve the problem?:

it has been mentioned here: jprichardson/electron-window#5 (comment)

from cerebro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.