cert-manager kubectl plugin does not support the `--context` flag about cert-manager

[ThatsMrTalbot]

👋 Is there a particular subcommand you are having issues with, looking at it the --context flag exists for subcommands that interact with Kubernetes.

For example:

$ kubectl cert-manager upgrade migrate-api-version --help 2>&1 | grep -- "--context"
      --context string                 The name of the kubeconfig context to use

$ kubectl cert-manager check api --help 2>&1 | grep -- "--context"
      --context string                 The name of the kubeconfig context to use

[taxilian]

... huh. It looks like when I was testing it I had the command wrong, and it works if I don't. For example:

$ kubectl cert-manager --context cluster3 check
.... (help stuff)
error: unknown flag: --context

however

$ kubectl cert-manager --context cluster3 check api
The cert-manager API is ready

So it looks like the actual bug is that if there is any syntax error and the context flag is present it will incorrectly report that the flag isn't supported =] much less critical, but confusing.

[ThatsMrTalbot]

Yea, the flag is only on the subcommands that talk to Kubernetes.

kubeclt cert-manager check does not, but kubeclt cert-manager check api does.

I think the confusion lies in the fact kubectl has the flag as a "global" flag available everywhere, where the cert-manager plugin does not.

I have noticed an inconsistency in that the kubectl cert-manager experimental install command has a different name for the flag:

kubectl cert-manager experimental install --help 2>&1 | grep context
      --kube-context string             name of the kubeconfig context to use

But that seems like a different issue

[taxilian]

I am not familiar enough with the internals to be sure where the error is coming from, but just to be clear here is the full output:

$ kubectl cert-manager --context cluster3 check
Usage: kubectl cert-manager [command]

Available Commands:
  api         Check if the cert-manager API is ready

Flags:
  -h, --help   help for check

Global Flags:
      --log-flush-frequency duration   Maximum number of seconds between log flushes (default 5s)
      --logging-format string          Sets the log format. Permitted formats: "json" (gated by LoggingBetaOptions), "text". (default "text")
  -v, --v Level[=2]                    number for the log level verbosity
      --vmodule pattern=N,...          comma-separated list of pattern=N settings for file-filtered logging (only works for text log format)

Use "kubectl cert-manager [command] --help" for more information about a command.

error: unknown flag: --context

It looks very much like the error "unknown flag: --context" is coming from the cert-manager plugin. Whether that's true or an illusion, I don't know =] Whatever the cause, the result is a help screen which appears to be very clearly explaining that --context is not a valid flag, hence my confusion.