Confusing variable naming in certbot/acme (private_key/privkey) about certbot

[osirisinferi]

The set_pubkey() method of the crypto.X509Req class accepts the OpenSSL.crypto.PKey class as argument. And that PKey can be a public key or key pair. When a key pair (private key) is used, it will extract the public key from the private key.

Notice how the private_key variable is really a private key, as it's being loaded from crypto.load_privatekey() and is also used by the csr.sign() method, which obviously requires a private key.

Thus the variable name is actually quite correct and personally I don't find it really confusing in the preamble of generate_csr() to be honest, as everybody knows it's the public part of the key pair/private key that gets embedded in the CSR.