GithubHelp home page GithubHelp logo

Comments (3)

elsif2 avatar elsif2 commented on June 11, 2024 1

The sys_ prefix was added inadvertently by an upstream update to our scanning tool. The prefix will not appear going forward from 2022-08-02.

from intelmq.

ClevenL avatar ClevenL commented on June 11, 2024

Another solution if value type preservation is preferred:
Include an additional definition that extracts sys_:

def convert_jitter_float(value: str) -> Optional[float]:
    """ 
    Returns an float or None for empty strings. 
    Used to preserve float value type for jitter
    field in ntp_version reports.
    """
    if re.match(r'^sys_', value):
        return float(value[4:]) if value else None

    return float(value) if value else None

and use it:

('extra.', 'jitter', convert_jitter_float),

from intelmq.

sebix avatar sebix commented on June 11, 2024

I don't know the intent of Shadowserver changing the type/content here, but removing the prefix sys_ looks cleaner to me. Except if there will be other prefixes in the future.
@elsif2 do you know more on this?

from intelmq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.