Comments (8)
PR is welcome, provided you're waving copyright claims and releasing the change under the existing V7 license.
from v7.
In interpreter.c
#ifdef V7_WINDOWS
static int signbit(double x) {
return x > 0;
}
#endif
I guess we can change the conditional to
#if defined(V7_WINDOWS) && _MS_VER > ....
from v7.
Probably yes, but we don't know the min value of _MS_VER
....
from v7.
https://msdn.microsoft.com/en-us/library/hh308342.aspx says 2013 and 2012 in "other versions."
http://stackoverflow.com/questions/70013/how-to-detect-if-im-compiling-code-with-visual-studio-2008 has a mapping of years to _MS_VER.
Let's go for 2012, _MS_VER 1700. Sending PR.
from v7.
Sergey, I really want to try pull some PRs, and I'm trying to understand what is individual contributor license (http://cesanta.com/contributors_la.shtml) and how to work with that... Do you know where to read about it in plain form (e.g. "для чайников"). Sorry for this off-topic.
from v7.
Тут вроде доступно написано: https://help.github.com/articles/creating-a-pull-request/
from v7.
Спасибо:) как готовить PRы, я в курсе:) мне не совсем понятно насчет contributor license - что это и зачем нужно...
from v7.
Это нужно для нашей защиты. Мы обязуемся перед нашими клиентами что наш код принадлежит нам, и мы не украли его у кого-то еще. Если кто-то шлет нам PR, он потенциально может оспорить это и подать на нас в суд. Подписание agreement нас от этого защищает. Вот вики: https://en.wikipedia.org/wiki/Contributor_License_Agreement
Так делают многие проекты - например https://github.com/influxdb, вот их соглашение: http://influxdb.com/community/cla.html
from v7.
Related Issues (20)
- V7 ScriptBASIC integration on Windows 7 32 bit HOT 41
- unit_test fails HOT 3
- v7_next_prop - No property attributes being returned HOT 10
- Script BASIC HOT 9
- v7.c: line:29703 /* TODO(dfrank) : add getter/setter support */ HOT 1
- How to load the byte code generated by v7_compile? HOT 4
- Can't call js function from C HOT 13
- Make user_data property as _V7_PROPERTY_OFF_HEAP HOT 1
- Problem running a basic test program HOT 2
- Segmentation Faults 2017-05-09
- Can I run under iOS? And Is it thread safe? HOT 2
- v7 support ajax?
- Trouble passing "true", "false" and "null" HOT 3
- v7_array_length issue HOT 1
- link errors since commit 8d8d8ce5... HOT 1
- Developer Centre down?
- C program crashes when trying to retrieve one of struct members as object member if below 0 HOT 4
- v7 Optimization tips
- Linker errors: Undefined symbols for architecture x86_64
- JSON.parse error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from v7.