Comments (4)
Is the FeatureCount used in CesiumJS (or another client)? Didn't have the impression it is. If not used, maybe it's an option to deprecate it?
from 3d-tiles.
From a quick full-text search, it does not seem to be used (it is read and stored in some property, but I don't see where it is actually used). Some questions about the featureCount
had already been raised in #624 , and that (and the linked issues) contain some justifications, but I couldn't immediately "map" this to the CesiumJS code right now.
So this issue may indeed be a clarification that goes beyond what it means - it may raise the question of whether it is required (or still required in CesiumJS), or whether it should or could be deprecated.
from 3d-tiles.
featureCount
would be relevant to CesiumJS as part of fixing CesiumGS/cesium#9884 to know how many Cesium3DTileFeature
objects to allocate.
from 3d-tiles.
I had a short look at the relevant parts of the codes - yes, a bit naive, by just doing a GitHub search for featureCount
in the whole CesiumGS organization and browsing through some parts of the respective (code) search results.
It looks like the featureCount
is rarely used. It is read, maintained, forwarded, updated, but cannot point my finger at a place where it is actually, technically, and strictly required. It's hard to be sure here, because ... it's a pretty generic term, there are some parts of the code where a "translation" from legacy versions of the extensions is going on, and it might be that the featureCount
is assigned from some count
value of a legacy extension, or vice versa.
A few places caught my attention:
- The type of a feature ID set is determined based on the feature count in https://github.com/CesiumGS/cesium-unreal/blob/fa463aef49e97c3e4df68645d354839358582145/Source/CesiumRuntime/Private/CesiumFeatureIdSet.cpp#L61
- The value seems to be exposed in a blueprint at https://github.com/CesiumGS/cesium-unreal/blob/fa463aef49e97c3e4df68645d354839358582145/Source/CesiumRuntime/Private/CesiumFeatureIdSet.cpp#L97 (meaning that it cannot be trivially be removed)
- Apparently, a missing
featureCount
in spec data caused trouble in CesiumGS/cesium-unreal#1360 (but I couldn't quickly identify the spot where it was required) - (The term appears at places like https://github.com/CesiumGS/cesium-unreal/blob/fa463aef49e97c3e4df68645d354839358582145/Source/CesiumRuntime/Private/CesiumEncodedMetadataUtility.cpp#L223 , but that may be a "false flag": This value is actually the property table
count
)
If the goal was to remove the featureCount
from the specification, then these parts may have to be investigated in more detail. But it looks like for the case of feature ID textures, the featureCount
actually is required for some implementations.
from 3d-tiles.
Related Issues (20)
- Maybe spell error HOT 1
- Clarify the use of non-8-bit-channels in property textures HOT 1
- How to format data HOT 1
- glTF metadata uses integers where it should use "glTF IDs" HOT 1
- Inconsistency in tile schema and its description
- Cesium 1.1 tiling data failed to load
- Can Earth Explorer 3D Map with Augmented reality be added as Viewer?
- Can Map Data Explorer iOS and Android be added as Viewer - it supports 3DTILES
- Selection Issue with GLB Model Organized by Tileset.json HOT 2
- Basic, minimal examples; sources for README figures HOT 10
- EXT_mesh_features Clarification: How many feature ids does an indexed geometry have when ids are implicitly derived? HOT 7
- EXT_mesh_features Rendering: How to visualize "interpolated" features? HOT 8
- 3D-Tiles 1.1 Implicit tile about .subtree binary file HOT 6
- Implementation notes refer to `bufferView` where `bitstream` should be used
- 3D-Tiles 1.1 implicit tile : Octree HOT 2
- 3D-Tiles 1.1 voxel HOT 1
- Clarification for content availability of implicit tileset roots HOT 4
- 3D-Tiles 1.1 voxel HOT 3
- 3D-Tiles 1.1 voxel's customShader HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 3d-tiles.