GithubHelp home page GithubHelp logo

Comments (6)

nisimpson avatar nisimpson commented on September 1, 2024 2

Hi all, any decisions made on this issue?

from action.

ryanovas avatar ryanovas commented on September 1, 2024 1

I would also like to know if there's any progress on this?

from action.

Andarist avatar Andarist commented on September 1, 2024

Hm, the git-flow is quite popular so I'm inclined to say that maybe we should provide better means to deal with this in the core.

It should be possible to add a step that would just change the base of created PR. Which we could make even easier if we'd output the PR number. The downside of this approach though is that it would mess up this search:

let searchQuery = `repo:${repo}+state:open+head:${versionBranch}+base:${branch}`;

As to the more built-in support for this - any ideas regarding the API, config option names etc?

from action.

pradel avatar pradel commented on September 1, 2024

I think my first idea (which might be wrong) is to have just a baseBranch and targetBranch option where I could set develop to baseBranch and master to targetBranch.

from action.

Andarist avatar Andarist commented on September 1, 2024

Hm, it could be still confusing to have those two in the config - although I agree that the chosen name has a nice ring to it. The problem is not really in that proposed flag, but more in the existing baseBranch - what people think about when they see a baseBranch?

That option would also only be relevant for the action here (at least for now) which kinda adds to the confusion. OTOH - the CLI (and its config) is a central place and people don't care that much how our architecture is fragmented right now in the CLI, Action, and Bot. So this could be thought of as a DX improvement.

@mitchellhamilton any particular thoughts about this?

from action.

emmatown avatar emmatown commented on September 1, 2024

Having a target branch option (in the action config, not the changesets config) seems fine.

from action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.