Comments (6)
Hi all, any decisions made on this issue?
from action.
I would also like to know if there's any progress on this?
from action.
Hm, the git-flow is quite popular so I'm inclined to say that maybe we should provide better means to deal with this in the core.
It should be possible to add a step that would just change the base of created PR. Which we could make even easier if we'd output the PR number. The downside of this approach though is that it would mess up this search:
Line 206 in c291823
As to the more built-in support for this - any ideas regarding the API, config option names etc?
from action.
I think my first idea (which might be wrong) is to have just a baseBranch
and targetBranch
option where I could set develop to baseBranch and master to targetBranch.
from action.
Hm, it could be still confusing to have those two in the config - although I agree that the chosen name has a nice ring to it. The problem is not really in that proposed flag, but more in the existing baseBranch
- what people think about when they see a baseBranch
?
That option would also only be relevant for the action here (at least for now) which kinda adds to the confusion. OTOH - the CLI (and its config) is a central place and people don't care that much how our architecture is fragmented right now in the CLI, Action, and Bot. So this could be thought of as a DX improvement.
@mitchellhamilton any particular thoughts about this?
from action.
Having a target branch option (in the action config, not the changesets config) seems fine.
from action.
Related Issues (20)
- More detail about pre-release, preState is not used HOT 1
- Custom pull request title HOT 3
- Does not work with peerDependencies HOT 1
- Action not started after PR merged HOT 1
- Support comments in config files HOT 1
- The listed users and repositories cannot be searched either because the resources do not exist or you do not have permission to view them. HOT 1
- Add feature to show npm errors when publishing to npm via GitHub Actions
- Changeset publish is failing HOT 1
- Publish automatically
- Publish pre-release while change-set pull-request is open HOT 2
- Disable publish to npm and only publish to github? HOT 1
- Workflow failing without proper error message HOT 14
- Action failing at logger error HOT 2
- fix: trying to publish when not needed HOT 1
- PR Creation fails HOT 3
- fix: handling `$` in changesets
- Custom Pull request title with tag version HOT 3
- createGithubReleases: true -> body is too long (max is 125000 characters) HOT 3
- Still try to create a new release PR when it already exists a PR HOT 1
- Auto merge / skip the automatic PR process HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from action.