GithubHelp home page GithubHelp logo

Comments (1)

Noviny avatar Noviny commented on May 7, 2024

I think this wants some minor/major changes to how bumping works. Currently file writing gets handed over to whatever function edits the file. Instead, all file edit functions return the new contents and the file path in an object, but don't write.

Finally, an end process does all file writing.

Bonus, we can add a check to make sure in any bump, we only have one instance of a file to write.

New pattern in bump effectively looks like:

const bump = (config) => {
  /* some setup stuff */

  let { errors: changelogErrors, files: changelogFiles } = await updateChangelogs(config)
  let { errors: pkgJsonErrors, files: pkgJsonFiles } = await updateVersions(config)

  if (changelogErrors || pkgJsonErrors ) / * handle this */

  await writeFiles([...changelogFiles, ...pkgJsonFiles])
}

from changesets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.