Comments (1)
I think this wants some minor/major changes to how bumping works. Currently file writing gets handed over to whatever function edits the file. Instead, all file edit functions return the new contents and the file path in an object, but don't write.
Finally, an end process does all file writing.
Bonus, we can add a check to make sure in any bump, we only have one instance of a file to write.
New pattern in bump effectively looks like:
const bump = (config) => {
/* some setup stuff */
let { errors: changelogErrors, files: changelogFiles } = await updateChangelogs(config)
let { errors: pkgJsonErrors, files: pkgJsonFiles } = await updateVersions(config)
if (changelogErrors || pkgJsonErrors ) / * handle this */
await writeFiles([...changelogFiles, ...pkgJsonFiles])
}
from changesets.
Related Issues (20)
- use changeset action on aws pipelines
- Cn not initialize changeset in my project it throws me an error HOT 4
- Changeset diff against the remote branch
- Cannot read properties of undefined (reading 'push') HOT 1
- Unexpected `Updated dependencies` changelog
- local registry set in .npmrc file not respected HOT 1
- Changesets bump the version of ignored packages
- Automatically commit/create changesets on PR's from specific users HOT 1
- A git `commit` _is_ a `changeset`. The name of this package and the bot are confusing.
- `version` should exit nonzero instead of only printing to stderr and bailing HOT 1
- Update package.json metadata to link to package directory inside monorepo HOT 1
- Prefer to generate a shorter tag name in monorepo.
- Adding an option to create comments using git commits
- Getting "E492: Not an editor command" error when trying to open the summary editor
- Support release to JSR
- When releasing, git tag isn't pushed.
- Allow usage of `changeset add` in a git pre-push hook HOT 2
- changelog Formatter in typescript don't work as expected
- [Request] Filter packages shown in CLI when writing a changeset HOT 2
- `changeset add` is ignoring the exit code of git commit
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from changesets.