WithTheme doesn't seem to change the theme about huh

[zx8]

@maaslalani Can this be re-opened? It seems #123 was reverted by commit 51377e6, so this is still an issue.

[maaslalani]

Thanks so much for reporting this issue @dfalgout, I will take a look.

[testinfected]

@dfalgout I had the same issue and workaround was to define the form myself, set form theme then add the widget to the form

[meowgorithm]

Off the cuff, I'd guess that this is only happening on one-off elements, i.e.

huh.NewMultiSelect().
    WithTheme(customTheme()).
    Run()

Whereas the following works in my testing:

huh.NewForm().
    WithTheme(customTheme()).
    Run()

[caarlos0]

my guess its a similar problem to #97

[jolheiser]

This is indeed semi-specific to using fields directly, but it's only because they use the global Run internally, which is the source of the issue.

In order from call site:

huh/field_multiselect.go

Line 425 in 355812c

return Run(m)

huh/run.go

Line 6 in 9cd22a8

form := NewForm(group).WithShowHelp(false)

huh/form.go

Lines 72 to 84 in 9cd22a8

	f := &Form{
	groups: groups,
	paginator: p,
	theme: ThemeCharm(),
	keymap: NewDefaultKeyMap(),
	width: 0,
	height: 0,
	results: make(map[string]any),
	}
	// NB: If dynamic forms come into play this will need to be applied when
	// groups and fields are added.
	f.WithTheme(f.theme)

huh/form.go

Lines 225 to 227 in 9cd22a8

	for _, group := range f.groups {
	group.WithTheme(theme)
	}

huh/group.go

Lines 95 to 97 in 9cd22a8

	for _, field := range g.fields {
	field.WithTheme(t)
	}

[maaslalani]

I believe this issue should be solved if we simply check if the theme or keymap is already set on the field before overriding it. This will make things work individually and allow changing themes / keymaps for individual fields as part of a larger form as well.

[maaslalani]

This should be fixed by #123, let us know if this works for you!

If it doesn't please feel free to re-open this issue or create a new one!

[mrkwtz]

Can confirm with 0.30.0 it's still an issue, please re-open.

[maaslalani]

Apologies! Thanks for letting us know, re-opened the issue for now.

[maaslalani]

Okay after a bunch of testing I believe I have solved it correctly this time, please do try it out and let me know if everything works correctly.

• #219