GithubHelp home page GithubHelp logo

`Hide` is not working about vhs HOT 12 OPEN

charmbracelet avatar charmbracelet commented on May 13, 2024
`Hide` is not working

from vhs.

Comments (12)

maaslalani avatar maaslalani commented on May 13, 2024 3

Oh interesting, that is a very good idea and would be quite useful, IMO. I generally agree that it is a little confusing what Hide does and maybe needs a bit more documentation or a rename.

Maybe Skip is a better name? And its counter part is Resume/Continue/Play?

from vhs.

maaslalani avatar maaslalani commented on May 13, 2024 2

Yep, do the Hide and all the typing and then clear the screen (by typing "clear" and Enter)

from vhs.

MarvinJWendt avatar MarvinJWendt commented on May 13, 2024 2

Just out of interest, why does Hide not hide the full command? IMO it's not actually "hiding" the stuff between Hide and Show, and for me it's not very obvious that Hide just disables the typing animation. Maybe a flag like Hide@animations and/or Hide@all would do the trick?

This could probably be expanded to Hide@cursor, Hide@colors, Hide@stderr and stuff like that.

from vhs.

MarvinJWendt avatar MarvinJWendt commented on May 13, 2024 1

Oh okay, got it! Is there any way to hide the full setup? Using the docker env I have to install some packages as they are not already in alpine (like curl), but I'd like to hide them from the user.

from vhs.

maaslalani avatar maaslalani commented on May 13, 2024

The hide command will hide frames from being recorded not the actual content of what is being typed. That is why the README shows that the command is already typed and you do not see the typing in the GIF but the typing does occur on the terminal.

from vhs.

MarvinJWendt avatar MarvinJWendt commented on May 13, 2024

Okay this seems to (kinda) work! The first few frames are still showing the output of apk add curl, but I think this will eventually be handled by #39 ?

from vhs.

maaslalani avatar maaslalani commented on May 13, 2024

Okay this seems to (kinda) work! The first few frames are still showing the output of apk add curl, but I think this will eventually be handled by #39 ?

Yes we'll definitely sort out the frames issue but to prevent it for now I think you can sleep for a little but after you've cleared the screen (but before the show)

from vhs.

maaslalani avatar maaslalani commented on May 13, 2024

But yes soon we'll have it so theres not extra frames cutting in. That is definitely a bug!

from vhs.

MarvinJWendt avatar MarvinJWendt commented on May 13, 2024

[...] I think you can sleep for a little but after you've cleared the screen (but before the show)

Works like a charmbracelet 😉

from vhs.

MarvinJWendt avatar MarvinJWendt commented on May 13, 2024

Maybe Skip is a better name? And its counter part is Resume/Continue/Play?

I'll leave the naming up to you, as I always struggle with it in my own projects 😆

Just another thing I noticed is, that with the clear command solution, it's currently not possible to hide steps between steps that should be visible. For example, my project is an automated installer, and to showcase it, the terminal needs to be reopened (because the $PATH changed). To simulate that, I source .profile after the installer runs, but before the installed program is called. Now I want to hide the source .profile in the middle.

This would also be handled then :)

from vhs.

griimick avatar griimick commented on May 13, 2024

Oh interesting, that is a very good idea and would be quite useful, IMO. I generally agree that it is a little confusing what Hide does and maybe needs a bit more documentation or a rename.

Maybe Skip is a better name? And its counter part is Resume/Continue/Play?

I too had trouble understanding it initially. Pause/Resume recording sounds better to me.

from vhs.

normanr avatar normanr commented on May 13, 2024

Pause and Resume will probably be the least confusing. Interestingly they behave very similar to Xoff(^S) and Xon(^Q).

(Also for what it's worth: compressed video players have to do something similar when doing a seek to a frame between two keyframes: they have to pause the video decoder's output, send it the previous keyframe, followed by all frames up to the frame it wants to show, then re-enable output and only then send it the frame it wants to display)

from vhs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.