do not ship a copy of sqlite about charybdis

[jillest]

The sqlite upstream recommends shipping the amalgamation with applications; I think it is probably best to follow that for charybdis itself.

If a distribution does not agree, they can use a patch.

[anarcat]

that's what we are doing, and that's what the above patch does.

but shouldn't we make it simpler for distributions to do this?

[Elizafox]

Following the recommendations of sqlite upstream is (imo) more important than appeasing distros.

[anarcat]

I keep on hearing that statement that sqlite upstream recommends amalgamation, yet I can't seem to find the source here.

I would like to avoid diverging too much with upstream (charybdis) in the debian package. Couldn't we at least make an option in the compile chain to use the installed sqlite at build time?

[grawity]

@anarcat: Did you mean http://www.sqlite.org/amalgamation.html?

In addition to making SQLite easier to incorporate into other projects, the amalgamation also makes it run faster. Many compilers are able to do additional optimizations on code when it is contained with in a single translation unit such as it is in the amalgamation. We have measured performance improvements of between 5 and 10% when we use the amalgamation to compile SQLite rather than individual source files. The downside of this is that the additional optimizations often take the form of function inlining which tends to make the size of the resulting binary image larger.

[anarcat]

This says amalgamation runs faster, but it doesn't say it's the recommended way.

[jillest]

As of 74273d8, we have a --with-shared-sqlite option.