GithubHelp home page GithubHelp logo

Comments (8)

kaniini avatar kaniini commented on September 26, 2024

Is this git, or...?

from charybdis.

anarcat avatar anarcat commented on September 26, 2024

sorry, this is 3.4.2. i haven't tried master.

from charybdis.

Heartmender avatar Heartmender commented on September 26, 2024

Please try git master.

from charybdis.

anarcat avatar anarcat commented on September 26, 2024

this also applies to git master:

build ==> ssld
make[1]: entrant dans le répertoire « /home/anarcat/src/charybdis/ssld »
gcc -I. -I../include -I../libratbox/include   -O0 -Wall -std=gnu99 -g -D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security  -DIRCD_PREFIX=\"/home/anarcat/ircd\" -c ssld.c
ssld.c: In function ‘ssl_process_accept_cb’:
ssld.c:686:3: warning: pointer targets in passing argument 2 of ‘rb_get_ssl_certfp’ differ in signedness [-Wpointer-sign]
In file included from ../libratbox/include/ratbox_lib.h:216:0,
                 from ../include/stdinc.h:26,
                 from ssld.c:25:
../libratbox/include/rb_commio.h:146:5: note: expected ‘uint8_t *’ but argument is of type ‘char *’
ssld.c: In function ‘ssl_process_connect_cb’:
ssld.c:709:3: warning: pointer targets in passing argument 2 of ‘rb_get_ssl_certfp’ differ in signedness [-Wpointer-sign]
In file included from ../libratbox/include/ratbox_lib.h:216:0,
                 from ../include/stdinc.h:26,
                 from ssld.c:25:
../libratbox/include/rb_commio.h:146:5: note: expected ‘uint8_t *’ but argument is of type ‘char *’
gcc -O0 -Wall -std=gnu99 -g -D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security  -DIRCD_PREFIX=\"/home/anarcat/ircd\" -Wl,-export-dynamic -Wl,-rpath=/home/anarcat/ircd/lib -o ssld ssld.o -L../libratbox/src/.libs -lratbox -ldl -lcrypt   -lz
make[1]: quittant le répertoire « /home/anarcat/src/charybdis/ssld »
build ==> bandb
make[1]: entrant dans le répertoire « /home/anarcat/src/charybdis/bandb »
gcc -I. -I../include -I../libratbox/include   -O0 -Wall -std=gnu99 -g -D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security  -DIRCD_PREFIX=\"/home/anarcat/ircd\" -DSQLITE_THREADSAFE=0 -DSQLITE_OMIT_LOAD_EXTENSION=1 -c bandb.c
bandb.c: In function ‘db_error_cb’:
bandb.c:292:2: error: format not a string literal and no format arguments [-Werror=format-security]
cc1: some warnings being treated as errors
make[1]: *** [bandb.o] Erreur 1
make[1]: quittant le répertoire « /home/anarcat/src/charybdis/bandb »
make: *** [build] Erreur 2

I tried with:

git co master
git pull
CFLAGS="-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security" ./configure
make

from charybdis.

Heartmender avatar Heartmender commented on September 26, 2024

The code it dies on

static void
db_error_cb(const char *errstr)
{
    char buf[256];
    rb_snprintf(buf, sizeof(buf), "! :%s", errstr);
    rb_helper_write(bandb_helper, buf);
    rb_sleep(2 << 30, 0);
    exit(1);
}

It dies on the snprintf call. Messing with the typing does not make the error go away.

from charybdis.

anarcat avatar anarcat commented on September 26, 2024

Note that this still applies to 3.4.2, as the kill module is not hardening-clean there. The problem is with those calls:

                sendto_one_numeric(source_p, ERR_CANTKILLSERVER, form_str(ERR_CANTKILLSERVER));

While are the same in 3.4 and master. The sendto_one_numeric() functions are the same in both, and so is the ERR_CANTKILLSERVER constant (483) and the resulting error (":You can't kill a server!").

I think it's because of the change in the form_str() prototype. In master, it's a define:

/*
 * form_str - return a format string for a message number
 * messages are defined below
 */

#define FORM_STR1(n)         NUMERIC_STR_##n
#define form_str(n)          FORM_STR1(n)

..while in 3.4 it's an actual function:

/*
 * form_str
 *
 * inputs       - numeric
 * output       - corresponding string
 * side effects - NONE
 */
const char *
form_str(int numeric)
{
        const char *num_ptr;

        s_assert(-1 < numeric);
        s_assert(numeric < ERR_LAST_ERR_MSG);
        s_assert(0 != replies[numeric]);

        if(numeric > ERR_LAST_ERR_MSG)
                numeric = ERR_LAST_ERR_MSG;
        if(numeric < 0)
                numeric = ERR_LAST_ERR_MSG;

        num_ptr = replies[numeric];
        if(num_ptr == NULL)
                num_ptr = replies[ERR_LAST_ERR_MSG];

        return (num_ptr);
}

In master, NUMERIC_STR_... are statically defined strings in the source, the one that concerns us:

#define NUMERIC_STR_483      ":You can't kill a server!"

... while in 3.4 it's a statically defined string, but part of the replies array:

static  const char *  replies[] = {
// [...]
/* 483 ERR_CANTKILLSERVER, */   ":You can't kill a server!",

This is where I get lost in the tangle - why would it make a difference if the string comes from a static array or just the source?

I understand master is now "clean", but i'd appreciate if I could get a fix for this for the 3.4 package too. Thanks!

from charybdis.

anarcat avatar anarcat commented on September 26, 2024

this still fails to build in 3.5.0:


make[1]: Entering directory '/tmp/buildd/charybdis-3.5.0'
build ==> libratbox
make[2]: Entering directory '/tmp/buildd/charybdis-3.5.0/libratbox'
Making all in src
make[3]: Entering directory '/tmp/buildd/charybdis-3.5.0/libratbox/src'
/bin/bash ./version.c.SH
Extracting libratbox/src/version.c...
/bin/cp version.c version.c.last
make  all-am
make[4]: Entering directory '/tmp/buildd/charybdis-3.5.0/libratbox/src'
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o unix.lo unix.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o win32.lo win32.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o crypt.lo crypt.c
crypt.c: In function 'rb_sha256_finish_ctx':
crypt.c:1366:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  *(uint32_t *) & ctx->buffer[bytes + pad + 4] = SHA256_SWAP(ctx->total[0] << 3);
  ^
crypt.c:1367:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  *(uint32_t *) & ctx->buffer[bytes + pad] = SHA256_SWAP((ctx->total[1] << 3) |
  ^
crypt.c: In function 'rb_sha512_finish_ctx':
crypt.c:1940:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  *(uint64_t *) & ctx->buffer[bytes + pad + 8] = SHA512_SWAP(ctx->total[0] << 3);
  ^
crypt.c:1941:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  *(uint64_t *) & ctx->buffer[bytes + pad] = SHA512_SWAP((ctx->total[1] << 3) |
  ^
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o balloc.lo balloc.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o commio.lo commio.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o mbedtls.lo mbedtls.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o openssl.lo openssl.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o gnutls.lo gnutls.c
gnutls.c: In function 'rb_load_file_into_datum_t':
gnutls.c:350:2: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
  fread(datum->data, datum->size, 1, f);
  ^
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o nossl.lo nossl.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o event.lo event.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o ratbox_lib.lo ratbox_lib.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o rb_memory.lo rb_memory.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o linebuf.lo linebuf.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o snprintf.lo snprintf.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o tools.lo tools.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o helper.lo helper.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o devpoll.lo devpoll.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o epoll.lo epoll.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o poll.lo poll.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o ports.lo ports.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o sigio.lo sigio.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o select.lo select.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o kqueue.lo kqueue.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o rawbuf.lo rawbuf.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o patricia.lo patricia.c
/bin/bash ../libtool --silent  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../include -I. -I../include  -I/usr/include/p11-kit-1   -Wdate-time -D_FORTIFY_SOURCE=2   -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o arc4random.lo arc4random.c
/bin/bash ../libtool --silent --mode=compile gcc -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -I. -I../include  -I/usr/include/p11-kit-1  -c version.c -o version.lo
/bin/bash ../libtool --silent  --tag=CC   --mode=link gcc  -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -Wall -lgnutls  -avoid-version -no-undefined -export-symbols export-syms.txt -fPIE -pie -Wl,-z,relro -Wl,-z,now -o libratbox.la -rpath /usr/lib/charybdis unix.lo win32.lo crypt.lo balloc.lo commio.lo mbedtls.lo openssl.lo gnutls.lo nossl.lo event.lo ratbox_lib.lo rb_memory.lo linebuf.lo snprintf.lo tools.lo helper.lo devpoll.lo epoll.lo poll.lo ports.lo sigio.lo select.lo kqueue.lo rawbuf.lo patricia.lo arc4random.lo version.lo -lgnutls  -lrt
make[4]: Leaving directory '/tmp/buildd/charybdis-3.5.0/libratbox/src'
make[3]: Leaving directory '/tmp/buildd/charybdis-3.5.0/libratbox/src'
make[3]: Entering directory '/tmp/buildd/charybdis-3.5.0/libratbox'
make[3]: Nothing to be done for 'all-am'.
make[3]: Leaving directory '/tmp/buildd/charybdis-3.5.0/libratbox'
make[2]: Leaving directory '/tmp/buildd/charybdis-3.5.0/libratbox'
build ==> modules
make[2]: Entering directory '/tmp/buildd/charybdis-3.5.0/modules'
gcc -fPIC -DPIC -shared -I../include -I../libratbox/include  -Wdate-time -D_FORTIFY_SOURCE=2 -O0 -Wall -std=gnu99 -g -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security  -DIRCD_PREFIX=\"/usr\" -fPIE -pie -Wl,-z,relro -Wl,-z,now core/m_ban.c -o core/m_ban.so
/usr/lib/gcc/x86_64-linux-gnu/5/../../../x86_64-linux-gnu/Scrt1.o: In function `_start':
(.text+0x20): undefined reference to `main'
/tmp/cc1wkI5Z.o: In function `m_ban':
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:63: undefined reference to `sendto_one_notice'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:64: undefined reference to `sendto_one_notice'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:66: undefined reference to `sendto_one_notice'
/tmp/cc1wkI5Z.o: In function `ms_ban':
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:93: undefined reference to `rb_current_time'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:117: undefined reference to `sendto_realops_snomask'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:126: undefined reference to `get_oper_name'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:129: undefined reference to `find_prop_ban'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:160: undefined reference to `deactivate_conf'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:165: undefined reference to `operhash_delete'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:185: undefined reference to `operhash_add'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:211: undefined reference to `valid_wild_card_simple'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:216: undefined reference to `get_oper_name'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:216: undefined reference to `sendto_realops_snomask'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:322: undefined reference to `rb_make_rb_dlink_node'
/tmp/cc1wkI5Z.o: In function `rb_dlinkAdd':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:144: undefined reference to `resv_conf_list'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:153: undefined reference to `resv_conf_list'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:152: undefined reference to `resv_conf_list'
/tmp/cc1wkI5Z.o: In function `ms_ban':
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:325: undefined reference to `CAP_BAN'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:325: undefined reference to `CAP_TS6'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:325: undefined reference to `sendto_server'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:139: undefined reference to `sendto_one_notice'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:238: undefined reference to `get_oper_name'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:238: undefined reference to `sendto_realops_snomask'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:249: undefined reference to `get_oper_name'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:249: undefined reference to `ilog'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:260: undefined reference to `get_oper_name'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:260: undefined reference to `sendto_realops_snomask'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:269: undefined reference to `get_oper_name'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:269: undefined reference to `ilog'
/tmp/cc1wkI5Z.o: In function `rb_strdup':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_memory.h:73: undefined reference to `rb_outofmemory'
/tmp/cc1wkI5Z.o: In function `ms_ban':
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:185: undefined reference to `operhash_add'
/tmp/cc1wkI5Z.o: In function `rb_strndup':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_memory.h:64: undefined reference to `rb_strlcpy'
/tmp/cc1wkI5Z.o: In function `ms_ban':
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:205: undefined reference to `valid_wild_card'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:175: undefined reference to `make_conf'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:178: undefined reference to `rb_make_rb_dlink_node'
/tmp/cc1wkI5Z.o: In function `rb_dlinkAdd':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:144: undefined reference to `prop_bans'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:152: undefined reference to `prop_bans'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:153: undefined reference to `prop_bans'
/tmp/cc1wkI5Z.o: In function `ms_ban':
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:287: undefined reference to `add_conf_by_address'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:288: undefined reference to `ConfigFileEntry'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:292: undefined reference to `kline_queued'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:294: undefined reference to `check_klines_event'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:294: undefined reference to `rb_event_addonce'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:297: undefined reference to `kline_queued'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:316: undefined reference to `add_to_resv_hash'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:317: undefined reference to `resv_chan_forcepart'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:309: undefined reference to `rb_make_rb_dlink_node'
/tmp/cc1wkI5Z.o: In function `rb_dlinkAdd':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:144: undefined reference to `xline_conf_list'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:152: undefined reference to `xline_conf_list'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:153: undefined reference to `xline_conf_list'
/tmp/cc1wkI5Z.o: In function `ms_ban':
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:310: undefined reference to `check_xlines'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:292: undefined reference to `kline_queued'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:227: undefined reference to `sendto_one_notice'
/tmp/cc1wkI5Z.o: In function `rb_strdup':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_memory.h:73: undefined reference to `rb_outofmemory'
/tmp/cc1wkI5Z.o: In function `rb_dlinkAdd':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:149: undefined reference to `prop_bans'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:150: undefined reference to `prop_bans'
/tmp/cc1wkI5Z.o: In function `ms_ban':
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:301: undefined reference to `check_klines'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:284: undefined reference to `remove_reject_mask'
/tmp/buildd/charybdis-3.5.0/modules/core/m_ban.c:306: undefined reference to `remove_reject_mask'
/tmp/cc1wkI5Z.o: In function `rb_strdup':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_memory.h:73: undefined reference to `rb_outofmemory'
/tmp/cc1wkI5Z.o: In function `rb_strndup':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_memory.h:63: undefined reference to `rb_outofmemory'
/tmp/cc1wkI5Z.o: In function `rb_dlinkAdd':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:149: undefined reference to `xline_conf_list'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:150: undefined reference to `xline_conf_list'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:149: undefined reference to `resv_conf_list'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_tools.h:150: undefined reference to `resv_conf_list'
/tmp/cc1wkI5Z.o: In function `rb_strdup':
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_memory.h:73: undefined reference to `rb_outofmemory'
/tmp/buildd/charybdis-3.5.0/modules/../libratbox/include/rb_memory.h:73: undefined reference to `rb_outofmemory'
/tmp/cc1wkI5Z.o:(.data.rel+0x20): undefined reference to `m_unregistered'
/tmp/cc1wkI5Z.o:(.data.rel+0x60): undefined reference to `m_ignore'
collect2: error: ld returned 1 exit status
Makefile:203: recipe for target 'core/m_ban.so' failed
make[2]: *** [core/m_ban.so] Error 1
make[2]: Leaving directory '/tmp/buildd/charybdis-3.5.0/modules'
Makefile:70: recipe for target 'build' failed
make[1]: *** [build] Error 2
make[1]: Leaving directory '/tmp/buildd/charybdis-3.5.0'

not sure why, but basically, i still can't enable the hardening flags in debian. without them, it builds fine.

from charybdis.

kaniini avatar kaniini commented on September 26, 2024

-Wl,-z,now probably doesn't work well with the way modules are lazily linked on charybdis < 3.6.

from charybdis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.