Inconsistent use of _GNU_SOURCE about charybdis

[anarcat]

can this be reproduce on the latest master branch? how about 3.4?

[kaniini]

please try with git master, we have no interest in 3.3 as it is many years old.

[tautschnig]

Hi! Apologies for the major delay in getting back to you. I cannot yet confirm that the above problem has been fixed (though it might have been), because I'm now getting the following error:
[...]
gcc -I../include -I../libratbox/include -DIRCD_PREFIX="/usr" -O0 -Wall -std=gnu99 -g -g -O2 -c version.c
gcc -O0 -Wall -std=gnu99 -g -g -O2 -Wl,-export-dynamic -Wl,-rpath=/usr/lib/charybdis -o ircd bandbi.o blacklist.o cache.o capability.o channel.o chmode.o class.o client.o extban.o getopt.o hash.o hook.o hostmask.o ipv4_from_ipv6.o irc_dictionary.o ircd.o ircd_signal.o listener.o logger.o match.o modules.o monitor.o newconf.o numeric.o operhash.o packet.o parse.o privilege.o ratelimit.o res.o reslib.o reject.o restart.o s_auth.o s_conf.o s_newconf.o s_serv.o s_user.o scache.o send.o snomask.o sslproc.o substitution.o supported.o tgchange.o whowas.o lex.yy.o y.tab.o version.o -L../libratbox/src/.libs -lratbox -ldl -lcrypt -lfl
file ircd_parser.y line 29: error: conflicting function declarations "yyerror"
old definition in module s_conf file s_conf.c line 1575
void (const char msg)
new definition in module y.tab file ircd_parser.y line 29
signed int (const char *)
make[2]: ** [ircd] Error 64

(This is while building Debian package version 3.4.2-3.)

Please let me know if you think this can be fixed; once it is, I will re-check the full package and let you know.

Best,
Michael

[jillest]

I think commit 67b7840 should fix the problem with yyerror().

[tautschnig]

My apologies for taking this long to respond (if such a response was actually sought): yes, I do confirm that the mentioned commit fixes the issue with yyerrror().

Best,
Michael