SSH key configuration no longer read from ~/.ssh/config about chef-workstation

[marcparadise]

This looks like the side effect of #176 - because we now always populate this into the target URL, the missing values in the identity portion get mapped to empty strings instead of nils. I'd been thinking anyway about changing the behavior to always use the train options map, and do not use the URL form except to resolve protocol. That should fix this behavior, without regressing #175 (which was fixed by #176)

[marcparadise]

This is being tracked internally as SHACK-252

[kmf]

Thanks for all the effort.

[marcparadise]

An partial fix is in place for this with #212 - but username will still default to 'root' even if .ssh/config has a User directive for the host - this will need to be fixed in train. We're looking into that now.
I'll keep this open until that is resolved as well.

[marcparadise]

Related: inspec/train#101 - I didn't verify port, but a quick look through train says that it still won't get picked up from config. It's got the same situation that 'user' does - it has a default in train, and if you don't provide it the default will be used. This prevents net/ssh from extracting it from config - its default behavior for these fields when values are not given.

[tyler-ball]

I think we fixed this with workarounds, so closing for now. Any upstream bugs we should track in the upstream repo