GithubHelp home page GithubHelp logo

Comments (7)

sersut avatar sersut commented on May 13, 2024

For this I think we need to make a fix similar to #1565 in https://github.com/opscode/chef/blob/master/lib/chef/application/solo.rb#L205.

Also maybe we should consider run_command -> shell_out conversion in Chef 12. Any concerns with that @danielsdeleo?

from chef.

danielsdeleo avatar danielsdeleo commented on May 13, 2024

converting to shell out is always good, provided we verify the behavior manually or with non-stubbed tests.

from chef.

adamhjk avatar adamhjk commented on May 13, 2024

Looking into this now.

from chef.

adamhjk avatar adamhjk commented on May 13, 2024

So, easy enough to fix the path problems, and flip this over to shell out. The real issue is the feature working at all on an un-modified Windows system. Even if you get this, you aren't going to wind up being able to untar without adding something to the machine that responds to 'tar zxvf'.

Would we rather add smarts to try tar and if it fails try 7-zip, and if that fails, die?

from chef.

sersut avatar sersut commented on May 13, 2024

We actually do ship a tar.exe with Chef Client and Chef DK so I don't think we need the backup plan:

C:\Users\Administrator>dir c:\opscode\chefdk\bin\tar.exe
 Volume in drive C has no label.
 Volume Serial Number is 46B7-7CAF

 Directory of c:\opscode\chefdk\bin

07/11/2014  11:29 PM            73,728 tar.exe
               1 File(s)         73,728 bytes
               0 Dir(s)  254,454,628,352 bytes free

from chef.

adamhjk avatar adamhjk commented on May 13, 2024

Dope. Patch incoming.

from chef.

coderanger avatar coderanger commented on May 13, 2024

#1751 is the PR for the future.

from chef.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.