Comments (13)
I'd rather just submit a PR if @chemerisuk will accept them. It affects both iOS and Android.
from cordova-plugin-firebase-dynamiclinks.
I think the recursion loop may be due to GoogleUtilities also swizzling the selector:
@selector(application:continueUserActivity:restorationHandler:);
So there's a 3 way infinite recursion loop of swizzling.
Perhaps this is a regression from a more recent version of Firebase/Core
?
Here is a page that explains how to register an interceptor which relies on GoogleUtilities swizzling:
https://github.com/firebase/firebase-ios-sdk/tree/master/GoogleUtilities/AppDelegateSwizzler
from cordova-plugin-firebase-dynamiclinks.
It seems that the swizzling should be removed, and AppDelegate selector declared straight up. Are you concerned about another plugin also using that delegate selector? I don't think that would work anyway with the way the Firebase SDK does its own swizzling.
Also, I'm still wondering how you would support posting an APP_DOMAIN url to javascript, since this plugin does declare its capability?
from cordova-plugin-firebase-dynamiclinks.
Hi @jacobg any updates on this issue?
Thanks!
from cordova-plugin-firebase-dynamiclinks.
I pulled this plugin into my own application repo, and changed it to remove swizzling and to also handle links that firebase does not handle. If @chemerisuk will accept PR's for those changes, I'll submit them.
from cordova-plugin-firebase-dynamiclinks.
from cordova-plugin-firebase-dynamiclinks.
Hi @jacobg any updates on this?
from cordova-plugin-firebase-dynamiclinks.
Waiting on @chemerisuk to say if he'll accept a PR.
from cordova-plugin-firebase-dynamiclinks.
from cordova-plugin-firebase-dynamiclinks.
I have solved the same problem. If you use custom domain,
how about you try checking "FirebaseDynamicLinksCustomDomains" in YourApp-info.plist.
more info:
https://firebase.google.com/docs/dynamic-links/ios/receive#open-dynamic-links-in-your-app
from cordova-plugin-firebase-dynamiclinks.
Hi @takedasoft do dynamic links work for you on iOS cold starts? In my case the deepLink result is lost because of handleOpenUrl being called after the initial resolveDeepLink
from cordova-plugin-firebase-dynamiclinks.
Same issue here
from cordova-plugin-firebase-dynamiclinks.
When using custom domains for Dynamic Links you could adjust this plugin.xml
and add:
<config-file target="*-Info.plist" parent="FirebaseDynamicLinksCustomDomains">
<array>
<string>https://$PAGE_LINK_DOMAIN</string>
<string>http://$PAGE_LINK_DOMAIN</string>
</array>
</config-file>
from cordova-plugin-firebase-dynamiclinks.
Related Issues (20)
- Deeplinks not working on facebook posts
- Error when building on monaca
- dynamiclinks.onDynamicLink not calling on IOS app HOT 5
- Deprecated method used on iOS HOT 1
- ERROR: UIApplication delegate (null) does not implements selector application:openURL:options:. FDL depends on this implementation to retrieve pending dynamic link. HOT 1
- onDynamicLink not firing on iOS 15.4 HOT 1
- ionic 5 + capacitor 3.5 iOS non-modular-header issue HOT 3
- Playstore disables "Open" button if coming from Dynamic Link HOT 1
- Capacitor integration fails while resolving Pods
- Firebase Configuration warning when running ionic cap sync command HOT 1
- cordova.plugins.firebase.dynamiclinks.getDynamicLink() throwing error
- Failed to fetch plugin cordova-plugin-firebase-dynamiclinks via registry.
- cordova-plugin-firebase-dynamiclinks permission prompt issue in IOS HOT 1
- Firebase Dynamic Links service will be shutting down in the future HOT 1
- Cannot read property 'createShortDynamicLink' of undefined HOT 2
- Dynamic link not recognized when app is being launched - again but this time in android HOT 2
- Firebase-dynamiclinks issue with plugin-firebase and firebasex
- createShortDynamicLink does not show image and description from socialMetaTagInfo HOT 1
- getDynamicLink method returns null on launch or open with dynamic link HOT 5
- "GoogleService-Info.plist" not found HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-plugin-firebase-dynamiclinks.