Does KB1 really need a special calculate_etendue function? about jet

[CnlPepper]

You could just add a ray max depth to the method and pass it through the Ray(). It'll only check for collisions within that range,

[jacklovell]

Thanks, I'll try that.

[mattngc]

Yeah, I think you can understand why it was custom (one of Matt's usual hack jobs :)). I think you really need to be careful with this reguardless of how you do it. The issue is that the full aperture is not a simple mesh file. You need to inject some special knowledge somewhere (i.e. CSG or max ray-depth, etc) otherwise it will definitely give you wrong results. The standard method will only work for systems without further occlusion beyond the pinhole. Anything beyond that is a more compount system.

[jacklovell]

I have to take the blame for this hack job, I'm afraid! But yes, I agree that this is a somewhat special case. I think adding an optional max ray depth to the calculate_etendue method will generalise it significantly, and so make it more useful for situations like KB1.

[jacklovell]

For the avoidance of confusion, @CnlPepper you mean ray.max_distance rather than ray.max_depth, right?

[jacklovell]

Fixed by #9