Error 23: ) does not have a value about mtg-photoshop-automation

[lambslamchops]

I got it to work! Thanks for everything!

[lambslamchops]

I do have to say the normal proxy works fine but it appears the other settings don't work. The new proxy.jsx file also has some missing bits like specified_template isn't defined and neither is exit_early. I assume you will get to these eventually but just thought I'd help. Thanks again so much!

[ndepaola]

hello - the script should automatically create card.json in the scripts folder when you run either proxy script, so it sounds like the command isn't working on your system. can you try pulling the refactor branch and run it again? if it fails to successfully run the python script, it'll now show you an error with the command it tried, which may help you debug. the python script also now no longer depends on any nonstandard libraries in case you were missing scrython or something. (also bear in mind that i'm committing to the refactor branch frequently atm and potentially with bugs)

[lambslamchops]

Now it tells me error 24: proxy is not a function. It must not see the proxy.jsx in the same folder.

[ndepaola]

hmm - on that branch the main function that proxy_target and proxy_all calls is proxy_new(), so i'm not sure why you're hitting that error w/o seeing your setup. did you download the refactor branch to a different folder on your computer so you're starting with a blank slate?

[lambslamchops]

Maybe I did it wrong, what do you mean by the refactor branch?

[ndepaola]

sorry, i should've clarified - i've been updating the project over here https://github.com/ndepaola/mtg-autoproxy/tree/refactor over the last week, but it's still a work in progress, hence why those changes aren't in the main version of the project yet. however i suspect i fixed the root cause of the issue you're experiencing on that branch. could you try downloading the code from that branch to a separate folder on your computer and run the scripts again?

[lambslamchops]

Okay now it returns: Error 48: File or folder does not exist.
Line: 1
-> #include "scripts/proxy.jsx";

[lambslamchops]

Sorry I rearranged the folders and it now returns
Line: 5
-> #include "..\settings.jsx";

[ndepaola]

understood - i'm downloading photoshop on my mac to test #include's and will get back to you when i've fixed it, it's probably a simple fix

[lambslamchops]

I changed the 5th line to #include "settings.jsx"; and that seemed to work,
now it seems to have an issue running the get_card_info.py script
I changed the line to say "python3" since that's how mac needs it to read but it still doesn't like the command when the script runs it, but if I manually type it, the terminal looks like this python3 /Users/adamryan/Desktop/working_directory/mtg-autoproxy-refactor/scripts/get_card_info.py "plains" Searching Scryfall for: plains... and done! Saving JSON... and done!

[ndepaola]

just tested this on my mac and i encountered the same issue - the terminal command was working from photoshop but it was failing to read the file - try replacing \\ with / in the json file path in constants.jsx. i'll do some more testing and see if it works with forward slashes on windows too, and update the rest of the project so it works on both platforms if so

[ndepaola]

should be fixed now

[lambslamchops]

Sadly, It still does not work. It returns this error now. I have all the templates downloaded so it must be something else.

[ndepaola]

what card are you running the script with? I haven't re-implemented transform, mdfc, or planar cards on the refactor branch yet - maybe try with a normal-border card?

[lambslamchops]

a basic plains

[ndepaola]

those two are defined in settings.jsx