Comments (8)
Seems like vite doesn't provide a polyfill for the node.js EventEmitter module when rolled up. I've just committed a polyfill I wrote real quick for it and published it to npm as v4.0.2, if you'd like to give it a try.
from scryfall-sdk.
I got quite the same error
Uncaught TypeError: Class extends value [object Object] is not a constructor or null at node_modules/scryfall-sdk/out/util/MagicEmitter.js (MagicEmitter.js:81:13) at __require (chunk-RSJERJUL.js?v=c7cb10fd:3:50) at node_modules/scryfall-sdk/out/api/Cards.js (Cards.js:21:24) at __require (chunk-RSJERJUL.js?v=c7cb10fd:3:50) at node_modules/scryfall-sdk/out/Scry.js (Scry.js:18:17) at __require (chunk-RSJERJUL.js?v=c7cb10fd:3:50) at Scry.js:89:26
from scryfall-sdk.
I'm going to need more info then unfortunately. Can you get me the .js file that's being produced by the bundler? Because it's definitely no longer the one provided by scryfall sdk, it has to be getting mangled in some way
from scryfall-sdk.
Thank for the reply
here is the MagicEmitter.js produced :
"use strict"; var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) { function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); } return new (P || (P = Promise))(function (resolve, reject) { function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } } function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } } function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); } step((generator = generator.apply(thisArg, _arguments || [])).next()); }); }; var __await = (this && this.__await) || function (v) { return this instanceof __await ? (this.v = v, this) : new __await(v); } var __asyncGenerator = (this && this.__asyncGenerator) || function (thisArg, _arguments, generator) { if (!Symbol.asyncIterator) throw new TypeError("Symbol.asyncIterator is not defined."); var g = generator.apply(thisArg, _arguments || []), i, q = []; return i = {}, verb("next"), verb("throw"), verb("return"), i[Symbol.asyncIterator] = function () { return this; }, i; function verb(n) { if (g[n]) i[n] = function (v) { return new Promise(function (a, b) { q.push([n, v, a, b]) > 1 || resume(n, v); }); }; } function resume(n, v) { try { step(g[n](v)); } catch (e) { settle(q[0][3], e); } } function step(r) { r.value instanceof __await ? Promise.resolve(r.value.v).then(fulfill, reject) : settle(q[0][2], r); } function fulfill(value) { resume("next", value); } function reject(value) { resume("throw", value); } function settle(f, v) { if (f(v), q.shift(), q.length) resume(q[0][0], q[0][1]); } }; Object.defineProperty(exports, "__esModule", { value: true }); const events_1 = require("events"); class MagicEmitter extends events_1.EventEmitter { constructor() { super(); this._ended = false; this._cancelled = false; this._willCancelAfterPage = false; this.mappers = []; this.on("end", () => { this._ended = true; }); this.on("cancel", () => { this._ended = true; }); } get ended() { return this._ended; } get cancelled() { return this._cancelled; } get willCancelAfterPage() { return this._willCancelAfterPage; } on(event, listener) { super.on(event, listener); return this; } emit(event, ...data) { if (event === "data") return super.emit(event, this.mappers.reduce((current, mapper) => mapper(current), data[0])); return super.emit(event, ...data); } emitAll(event, ...data) { for (const item of data) { super.emit(event, event !== "data" ? item : this.mappers.reduce((current, mapper) => mapper(current), item)); if (this._cancelled) break; } } cancel() { this._cancelled = true; this.emit("cancel"); return this; } cancelAfterPage() { this._willCancelAfterPage = true; return this; } waitForAll() { return __awaiter(this, void 0, void 0, function* () { return new Promise((resolve, reject) => { const results = []; results.not_found = []; this.on("data", result => { results.push(result); }); this.on("not_found", notFound => { results.not_found.push(notFound); }); this.on("done", () => resolve(results)); this.on("error", reject); }); }); } [Symbol.asyncIterator]() { return this.generate("data"); } all() { return this.generate("data"); } notFound() { return this.generate("not_found"); } map(mapper) { this.mappers.push(mapper); return this; } generate(event) { return __asyncGenerator(this, arguments, function* generate_1() { // save the new data on each event const unyielded = []; this.on(event, data => unyielded.push(data)); while (!this._ended) { // wait for the next event before yielding any new data yield __await(new Promise(resolve => this.once(event, resolve))); let data; while (data = unyielded.shift()) yield yield __await(data); } }); } } exports.default = MagicEmitter;
from scryfall-sdk.
This is not the latest version of scryfall-sdk, you can tell because it says const events_1 = require("events");
which was changed to const EventEmitter_1 = require("./EventEmitter");
in v4.0.2. Please update your scryfall-sdk version and try again
from scryfall-sdk.
Hi
Here is my project : https://github.com/Daniel-Venera/mtg-draft-vue
and I use the latest version 4.1.0 :/
from scryfall-sdk.
So it looks like rather than throwing an error on encountering a node module it doesn't support, it instead just returns an empty object, which causes scryfall-sdk to not error and use its polyfill. (Why does it work like this????) I'll fix it. Thank you for the example project to test with!
from scryfall-sdk.
wonderful thanks a lot !
from scryfall-sdk.
Related Issues (20)
- TsLint assumes system file structure
- `frame_effect` removal, `frame_effects` and `preview` additions HOT 3
- Update README (out of date)
- Update type Card
- Runtime error with interfaces exported from Scry module: Cannot read property 'collection' of undefined HOT 2
- All Cards api route deprecated HOT 1
- `gulp build` step emits declaration files with errors. HOT 3
- Failed Fuzzy search returns a strange format HOT 1
- Card Imagery HOT 1
- Search for a set HOT 1
- `.cancelAfterPage().waitForAll()` never resolves HOT 5
- svg_uri missing from CardSymbol HOT 2
- Test failures after Scryfall API changes
- Cards.bySet does not allow for string collectorNumber
- Why add empty card_faces array? HOT 7
- Tagger api support HOT 2
- add penny_rank to Card definition
- webpack - node:events error in EventEmitter HOT 4
- this._listeners[eventName] is not iterable HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scryfall-sdk.