Use MSYSTEM_PREFIX about setup-ccache-action

[silverqx]

Thank you, for the patch.

I have setup it yesterday and it works for me, invoked like this:

    - name: ccache setup 🕺
      uses: Chocobo1/setup-ccache-action@v1
      with:
        windows_compile_environment: msys2
        prepend_symlinks_to_path: false
        install_ccache: false
        update_packager_index: false
        ccache_options: |
          compiler_check = %compiler% -v
          compression = false
          max_size = 3G

We will see, I don't know why it is failing when I have a problem like this, then I use this after failing action:

    - name: Setup tmate session
      uses: mxschmitt/action-tmate@v3
      with:
        limit-access-to-actor: true

    - run: exit 1

Then ssh into the runner and try to invoke commands directly in the runner, but it looks like that fail exits the whole job so what I'm writing above will be useless for you.

We will see and I don't have too much time to investigate it, to be honest.

[Chocobo1]

It seems msys2 has done some update, now I can properly test my code.

And I found out that need to revert some of my changes and that includes declining/reverting what you suggested here. The reason is that MSYSTEM_PREFIX is only available within msys2 shell and not in the shell that setup-ccache-action is using.

Here you can see MSYSTEM but no MSYSTEM_PREFIX: https://github.com/Chocobo1/setup-ccache-action/runs/4392064323?check_suite_focus=true#step:4:89

Also just to be sure, msys2 is on windows so the filesystem is case-insensitive therefore using MSYSTEM (instead of MSYSTEM_PREFIX) shouldn't really affect you, right?

[Chocobo1]

Hi @Chocobo1, thx for the great GH action.

You are welcome.

should be? MINGW_PREFIX or MSYSTEM_PREFIX:
return ${Process.env.MINGW_PREFIX}/lib/ccache/bin;

That probably would be good, applied in 243d077.

I'm not sure what is the difference between MSYSTEM_PREFIX and MINGW_PREFIX

Looks like MINGW_PREFIX is just an alias for MSYSTEM_PREFIX.

Also note that the msys testing CI is broken currently and I have no idea what caused it, it was working fine a few days ago. Last working instance: https://github.com/Chocobo1/setup-ccache-action/actions/runs/1458477952
I tried to replicate locally but it fails to show the symptom, i.e. it was working fine locally.

So msys support currently is in a perverted state and I cannot fully guarantee that it is working...

[Chocobo1]

I have setup it yesterday and it works for me, invoked like this:

Seems you skipped all possible failing points (by accident?), good for you.

We will see, I don't know why it is failing when I have a problem like this, then I use this after failing action:

Thanks! I'll take a look when I got the time.

[silverqx]

Seems you skipped all possible failing points (by accident?), good for you.

That is true, I'm installing ccache myself, I'm not using prepend_symlinks_to_path because cmake has a problem with ccache wrappers when I use ninja.

So I'm practically using only caching capabilities of ccache's cache dir 😂 from this action and I also like output statistics.

[silverqx]

Ok, thank you for info, it does not matter at the end of the day.