POST /api/v1/videos/{id}/views return 400 about peertube

[kontrollanten]

Describe the current behavior

Currently the client can send float value to POST /api/v1/videos/{id}/views, which isn't accepted by the API due to validators.isInt check

PeerTube/server/core/middlewares/validators/videos/video-view.ts

Line 36 in 01e4fd0

.custom(isIntOrNull),

PeerTube/server/core/helpers/custom-validators/misc.ts

Line 71 in 01e4fd0

return value === null || validator.default.isInt('' + value)

isInt returns false when passing a float value:

validator.isInt('13.12123123')
false

The client code that's sending the float is probably this:

PeerTube/client/src/assets/player/shared/peertube/peertube-plugin.ts

Lines 254 to 258 in 01e4fd0

	this.videoViewOnPlayHandler = () => {
	debugLogger('Notify user is watching on play: ' + startTime)
	this.notifyUserIsWatching(startTime, lastViewEvent)
	}

Describe the expected behavior

Either the client should send an int or the API should be more forgiving and converting float to int.

Additional information

• PeerTube instance:

  • URL:
  • Version: 6.0.3
  • NodeJS version:
  • Ffmpeg version:

• Browser name, version and platforms on which you could reproduce the bug:

• Link to browser console log if relevant:

• Link to server log if relevant (journalctl or /var/www/peertube/storage/logs/):

[Chocobozzz]

Currently the client can send float value to POST /api/v1/videos/{id}/views, which isn't accepted by the API due to validators.isInt check

Are you sure? In your example I don't see where startTime can be a float, and other notifyUserIsWatching calls use Math.floor (like https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/assets/player/shared/peertube/peertube-plugin.ts#L350)

[kontrollanten]

Yes, at least we see that the REST API receives floats from the web client.

In peertube-plugin.ts startTime is defined in two places:

PeerTube/client/src/assets/player/shared/peertube/peertube-plugin.ts

Line 243 in 01e4fd0

const startTime = timeToInt(this.options.startTime())

PeerTube/client/src/assets/player/shared/peertube/peertube-plugin.ts

Line 439 in 01e4fd0

const startTime = this.options.startTime()

The first one is using timeToInt for a reason I guess? I haven't dug deep into this, I've just noticed we receive floats from the web client in our error logs.

[Chocobozzz]

Thanks, then I think ca889db will fix the issue. Don't hesitate to comment if you still notice bad requests after applying this patch (don't forget some web browser may still have the old client in cache/as pwa so the user agent can help)