GithubHelp home page GithubHelp logo

Question around polyfills about choices HOT 6 CLOSED

choices-js avatar choices-js commented on April 28, 2024
Question around polyfills

from choices.

Comments (6)

jshjohnson avatar jshjohnson commented on April 28, 2024 1

Good point, I had always assumed requestAnimationFrame had poor support. I'll move this out of the build in the next release. Thanks

from choices.

jshjohnson avatar jshjohnson commented on April 28, 2024 1

The requestAnimationFrame polyfill has been removed as of version 1.1.7

from choices.

jshjohnson avatar jshjohnson commented on April 28, 2024

I'm definitely open to this. My only reservation is that people miss a particular polyfill, get an error and assume the library has bugs!

from choices.

zslabs avatar zslabs commented on April 28, 2024

Yeah I hear ya. Can be a tougher transition with existing repos, but something that can be approached through documentation. Obviously a bit of a buy-in to promote a service like http://polyfill.io but there certainly are some other options out there; especially if users have their own implementation.

from choices.

jshjohnson avatar jshjohnson commented on April 28, 2024

I have updated the documentation to recommend polyfill usage where needed: https://github.com/jshjohnson/Choices#browser-compatibility

I have kept the polyfill for Array.from and window.requestAnimationFrame within the Choices bundle as they are required for the plugin to function.

Thanks for the heads up.

from choices.

zslabs avatar zslabs commented on April 28, 2024

Cool! That's a great addition to the README. One quick note around keeping requestAnimationFrame - since the browser compat list mentions only browsers that support es5 it looks like the former has very similar support for it, so something maybe to be considered for the future. Thanks!

from choices.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.