GithubHelp home page GithubHelp logo

Comments (4)

jshjohnson avatar jshjohnson commented on April 29, 2024 8

In version 2.2.4 Webpack now wraps Choices in a UMD wrapper. This means you should be able to import it using require('choices.js') or import Choices from 'choices.js'. If it is included directly on the page, it will be attached to the global window.

If there are any issues with the new version, let me know ASAP!

Thanks 👍

from choices.

superelement avatar superelement commented on April 29, 2024 7

This worked for me using Typescript
import * as Choices from 'choices.js'

from choices.

rstacruz avatar rstacruz commented on April 29, 2024

I don't know exactly why this is, but here's something strange.

In choices.js line 2175, it sets window.Choices and module.exports.

2175  window.Choices = module.exports = Choices;

This is in conflict with export default in line 34.

34    export default class Choices {

I recommend:

  • don't use export default, instead just use module.exports. This allows you to make a package that can be used by both ES5 (require(...)) and ES6 transpilers (import).
  • Alternatively, just use export default instead; however, be aware of the caveat of this. redux-thunk is one package that follows this convention.
  • Avoid setting window.Choices explicitly. This will avoid global namespace pollution. Instead, generate a UMD build with Webpack. (I think that's libraryTarget: 'umd', but i'm not much of a Webpack user...)

from choices.

lvpro avatar lvpro commented on April 29, 2024

I think module is just getting shadowed.

This is how I solved the problem ...

At the top of choices.js:
const CJSModule = module;

Then replace exports.default and window.Choices with:
CJSModule.exports = Choices;

Then you can:
import Choices from 'choices.js'

:)

from choices.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.