problem bundling hypercore: 'require is not defined' about bankai

[yoshuawuyts]

Hmm, odd. We're enabling some optimizations for build that we don't for start. I wonder what the culprit might be.

[goto-bus-stop]

it seems to be using sodium-native instead of sodium-javascript in prod for some reason.

[goto-bus-stop]

hypercore has a conditional call to require('fd-lock'). browser-pack-flat is overeager about inlining it. fd-lock doesn't work in the browser, so hypercore should probably explicitly exclude it using the browser field in package.json:

"browser": {
  "fd-lock": false
}

but it's also something that should be addressed in browser-pack-flat. it doesn't currently try to check if a require call may be conditional.

[rhodey]

wow thanks for the quick research @goto-bus-stop! I tried debugging this myself yesterday but I'm very unfamiliar with bankai and js bundling in general. If you have any tips to share on your debug process I'm very curious to know. either way thanks! sounds like i should close this out and re-open a similar report on browser-pack-flat