GithubHelp home page GithubHelp logo

Comments (3)

goto-bus-stop avatar goto-bus-stop commented on September 22, 2024 1

I wouldn't be opposed to a dependency injection like API like you suggest. I think to implement it, the simplest way is to:

  1. move all of lib/browser.js to a new lib/dom.js file
  2. wrap lib/dom.js in a big closure that takes a document argument
  3. update lib/browser.js to do module.exports = require('./dom')(document)
  4. add a new /dom.js module that exports ./lib/dom.js (similar to how we have /raw.js already)
  5. add some tests using jsdom or whatever (that would only run on node.js versions still supported by jsdom)

then it could be released as a minor version.

I don't really wanna do it myself 🙈 but would review a PR, whether it takes the above approach or a different one!

from nanohtml.

goto-bus-stop avatar goto-bus-stop commented on September 22, 2024

There could be a new nanohtml/dom API that does that, but you can also do this today:

var html = require('nanohtml/lib/browser')

global.document = jsdomDocument
var el = html`
  <h1>uses jsdom</h1>
`

or:

function html (document) {
  var inner = require('nanohtml/lib/browser')
  return function (strings, ...expressions) {
    global.document = document
    var result
    try {
      return inner(strings, ...expressions)
    } finally {
      delete global.document
    }
  }
}

from nanohtml.

saschanaz avatar saschanaz commented on September 22, 2024

The maintainer of hyperhtml suggested same thing but I don't want to pollute global scope. (And I hope there be no hack modifying and de-modifying global scope.)

from nanohtml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.