GithubHelp home page GithubHelp logo

Preview Fails to Render about haze HOT 3 CLOSED

chrisbanes avatar chrisbanes commented on August 21, 2024
Preview Fails to Render

from haze.

Comments (3)

chrisbanes avatar chrisbanes commented on August 21, 2024

Thanks for the report!

This is tricky as the Modifier.Node APIs don't make it easy to delegate based on a composition local value. We can use DelegatingNode and DelegatableNode, but it's going to require a large refactoring of the codebase for it to work. The short summary is that we'll need to create a wrapper DelegatingNode, which delegates to HazeNode31 or HazeNodeBase based on the value of SDK_INT and LocalInspectionMode. That will fix issue 2.

I don't think there's much we can do about issue 3. There is a coupled relationship between haze and hazeChild and I don't want to create hacks just for previews.

from haze.

chrisbanes avatar chrisbanes commented on August 21, 2024

For now, I'm going to fix the crash by no-op'ing the main haze modifier when LocalInspectionMode is true.

from haze.

jakobulbrich avatar jakobulbrich commented on August 21, 2024

For now, I'm going to fix the crash by no-op'ing the main haze modifier when LocalInspectionMode is true.

Thanks for the quick fix. Now at least the preview does not crash anymore 👍
Would be very nice to have this delegation to HazeNode31 or HazeNodeBase also depending on LocalInspectionMode.

I don't think there's much we can do about issue 3. There is a coupled relationship between haze and hazeChild and I don't want to create hacks just for previews.

It would be nice if we could configure the tint color on hazeChild side. But I guess it is not easily possible, unless we are using the HazeState just as a registry to pass the bounds and desired tint color. But this raises the question how it behaves if multiple colors are set for the same area by different children and if the order of drawing them could be guaranteed.

from haze.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.