GithubHelp home page GithubHelp logo

Comments (5)

chrisbanes avatar chrisbanes commented on August 21, 2024 1

Just had a quick look into this. So we map all hazeChild positions using positionInRoot (root being the root composable), which is the simplest way to handle this 95% of the time. Dialogs however are put into their own android.view.Window on Android, which means that they're not part of the original root composable. They have their own root composable, with its content being displayed at 0,0, hence why the blurring is at the top left.

To fix this we need to calculate everything in 'screen' coordinates, by passing along the window offset when sending the hazeChild positions. That's not particularly difficult, but we need to do it in a way which works across platforms, which is probably going to be trickier.

from haze.

chrisbanes avatar chrisbanes commented on August 21, 2024

Got a small repro sample? I'm not surprised this doesn't work out of the box to be honest

from haze.

poliver avatar poliver commented on August 21, 2024

https://github.com/poliver/HazeDialogRepro

from haze.

chrisbanes avatar chrisbanes commented on August 21, 2024

Thanks!

from haze.

poliver avatar poliver commented on August 21, 2024

Thanks for taking a look

from haze.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.