GithubHelp home page GithubHelp logo

Comments (1)

matthutchinson avatar matthutchinson commented on June 2, 2024

I can confirm this is necessary when using FakeWeb to stub requests from the RestClient gem (2.0.0+).

Without inspecting this IO stream data, there's no way to see what was sent. Since FakeWeb.last_request.body will be nil in the common case of sending a String payload with RestClient::Request.execute(...).

It is due to this code in RestClient::Request creating a RestClient::Payload::Base (or similar depending on the type of body data) and attaching it to the Net::HTTP request body_stream (rather than body).

This was documented here as a performance improvement with the release of RestClient v2.0.0

Add actual support for streaming request payloads. Previously rest-client would call .to_s even on RestClient::Payload::Streamed objects. Instead, treat any object that responds to .read as a streaming payload and pass it through to .body_stream= on the Net:HTTP object. This massively reduces the memory required for large file uploads.

This isn't an issue with Net::HTTP unless you're setting body_stream directly on the request.

from fakeweb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.