GithubHelp home page GithubHelp logo

Comments (3)

chrisrhymes avatar chrisrhymes commented on May 21, 2024

Hi,

Thanks for reporting this. I added the favicon url from this pull request. I intended to package a default favicon with the theme but it doesn't seem to have worked so I'll take a look at that when I can.

Do you think it would be useful to have a variable in the _config.yml to overwrite the default favicon path? Something like:

favicon: path/to/favicon.png

Then update the head.html to the following:

 <link rel="shortcut icon" type="image/png" {% if site.favicon %} href="{{ site.favicon | prepend: site.baseurl }}" {% else %} href="{{ site.baseurl }}/favicon.png" {% endif %} /> 

from bulma-clean-theme.

marcello-dev avatar marcello-dev commented on May 21, 2024

Yes, this fix looks good, thanks!
In the README you can specify that png is the extension supported for now. Unless you want to parametrize it too.

from bulma-clean-theme.

chrisrhymes avatar chrisrhymes commented on May 21, 2024

@marcello-dev I've updated the readme as suggested and also added the ability to override the default.

from bulma-clean-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.