Not working on Pidgin 2.12.0 about pidginwintoastnotifications

[ChristianGalla]

Thanks for reporting this bug.

I am usually only programming for the newest Pidgin version and have never tested an older version.

If an older Pidgin version is used, the plugin may call a Pidgin function that not exists and therefore fails.
That is the reason I suggest using the newest Pidgin version.

If it is not possible to use the newest Pidgin version, can you please have a look in the error search window and let me know, if there are any plugin related error messages?

[b2cbd]

@ChristianGalla Thanks for checking out the issue. Here is the debug log for 1.6.1 @ Pidgin 2.12.0!

plugins: probing C:\Program Files (x86)\Pidgin\plugins\PidginWinToastNotifications.dll
plugins: C:\Program Files (x86)\Pidgin\plugins\PidginWinToastNotifications.dll is not loadable: ABI version mismatch 2.13.x (need 2.12.x)

I believe you've to lower PURPLE_MINOR_VERSION and re-compile.

[ChristianGalla]

I have build the plugin for Pidgin 2.12.0 and attached it to the last release.

Can you please test if it works on your machine?

[b2cbd]

@ChristianGalla Thanks I used lib file form 1.6.1 and this DLL - I confirm it works in Pidgin 2.12.0 (libpurple 2.12.0).

There could be an enhancement for the next version. For some protocols like Whatsapp/Facebook, when I logged in using Pidgin but send a message using my phone app, this plugin shows notification for my own message with the wrong sender name. It could filter notification for only incoming messages, not the outgoing ones.

I really appreciate all the hard work you've done here.

[ChristianGalla]

When you send a message via phone, which sender name is displayed in Pidgin?

Are there protocols where this does not happen?

If this is a protocol specific issue, this issue may be in the scope of the protocol plugin.

[b2cbd]

@ChristianGalla This happens only for WhatsApp and Facebook protocol, they are the HTTP protocol. Other protocols like Google-XMPP is fine.

It shows the receiver-name on notification, though it was an outgoing message. It supposes to show notification only for incoming messages. In the chat window, it shows my name correctly for this message.

[ChristianGalla]

@b2cbd It seems you have created an issue in the WhatsApp plugin and there was a commit addressing the issue about receiving of own messages that were send from another device. I hope the next Windows build of the WhatsApp plugin fixes this issue.

Because the initial issue (working on Pidgin 2.12.0) was resolved and it looks like the other issue you reported is in the scope of the protocol plugins, I am closing this issue.
If you are experiencing any additional issues or have a feature request feel free to open a new issue.