Reface DX edit buffer import doesn't work about knobkraft-orm

[christofmuc]

Let me think about this - not all Synths support the import edit buffer operation, ideally the button would be disabled if the synth can't do it.

The Reface DX spec offers a "dump request" function, which would already be implemented. We would have to test if that function returns the stored patch or the patch that is modified (sometimes synth would only return the memory data, not the edited data).

You could test that by modifying a patch, and then without pressing store do a bank load. If the modified patch is retrieved, we could hook up the dump request to the import edit buffer function.

Alternatively, there is a parameter request call, but then we'd have to test if those would return the edited (nont stored) patch, and if that works, issue a flood of parameter requests.

[christofmuc]

Ups, only now seeing on your screen that the Orm actually thought it had downloaded a patch - that indicates a corrupted patch somehow. I'll mark this as bug and have to try to reproduce.

[christofmuc]

Ok, I tried it on my RefaceDX, and it seems to work surprisingly - if you edit a patch, and do the request again, you will get the edited patch. There is a bug in the edit buffer download for the RefaceDX which I will fix and release for the new version.

You could test that by modifying a patch, and then without pressing store do a bank load. If the modified patch is retrieved

Is that a correct test scenario?

1. Edit e.g. DigiChord (Bank1-1) patch on Reface without storing
2. Press "Import patches from synth" in KnobKraft-orm
3. Press on DigiChord patch in KnobKraft-orm to send it to Reface

This way I only get memory DigiChord, not the edited one

[christofmuc]

#3 Should not be necessary. If the system says after #2 "no new patches", then it didn't detect the change. But I think I know the problem - when it retrieves a patch via "import patches", it will issue a program change first, which will overwrite your change. The new version will send a dump request without the program change, and I think this will work. Maybe I can get it done by today.

If the system says after #2 "no new patches", then it didn't detect the change. But I think I know the problem - when it retrieves a patch via "import patches", it will issue a program change first, which will overwrite your change

Seems that is!

The new version will send a dump request without the program change, and I think this will work. Maybe I can get it done by today.

Thank you! 😄

[christofmuc]

Hopefully fixed with release 1.6.0 24fd6ad

It fixed, thank you very much!